Ticket #6216 (closed: fixed)
ParaView peaks reader plugin should be more flexible.
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.4 |
| Component: | VATES | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6479 | Tester: | Michael Reuter |
Description
It should be possible to load either .peaks or (more recently) .nxs files, each of which produce a peaks workspace.
Attachments
Change History
comment:2 Changed 8 years ago by Owen Arnold
refs #6216. Better file type identification.
Changeset: 5a9186dd5c058b75f82c489c489a789d0ce30394
comment:3 Changed 8 years ago by Owen Arnold
refs #6216. Can handle both peak type formats now.
Changeset: ef1ab9ca36bda83f5953687d6e853886c2e9d8c2
comment:4 Changed 8 years ago by Owen Arnold
refs #6216. Fix warnings.
Changeset: 210050b2635001aa532edeea3cf5804f0fca3d79
comment:5 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester. At this stage we do not have a GUI test framework, and the code is not fully MVP, so the testing will have to be entirely manual. Here is a guide to help.
- In Mantid take a peaks workspace and save it out twice. The first time, save it out using SaveISAWPeaks to a *.peaks file, the second time to a *.nxs file using SaveNexus.
- Launch ParaView (ensure PV_PLUGINS_PATH has been set to point at the Mantid pv_plugins)
- Load the *.peaks file in ParaView, ParaView should be able to select the relevant Plugin Reader without being prompted any further. Hit 'Apply' and the Peaks Workspace should appear in PV.
- Load the *.nxs file into Paraview, ParaView should be able to identify this as a PeaksWorkspace type nexus file and load it.
- Both visualisations should look identical.
comment:6 Changed 8 years ago by Owen Arnold
refs #6216. Fix warning.
Changeset: 886a8b1d5300006e3b68cd376a5e98e5bc2135b8
comment:7 Changed 8 years ago by Owen Arnold
refs #6216. Better file type identification.
Changeset: 5a9186dd5c058b75f82c489c489a789d0ce30394
comment:8 Changed 8 years ago by Owen Arnold
refs #6216. Can handle both peak type formats now.
Changeset: ef1ab9ca36bda83f5953687d6e853886c2e9d8c2
comment:9 Changed 8 years ago by Owen Arnold
refs #6216. Fix warnings.
Changeset: 210050b2635001aa532edeea3cf5804f0fca3d79
comment:10 Changed 8 years ago by Owen Arnold
refs #6216. Fix warning.
Changeset: 886a8b1d5300006e3b68cd376a5e98e5bc2135b8
comment:11 Changed 8 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:12 Changed 8 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
It looks like the ISAW peaks file uses the default peak radius (0.05) when plotting in ParaView and ignores the true radius while the NeXus file version ignores this default and plots the correct radius. See the attached picture. The red spheres are the ISAW peaks and the wireframes are the NeXus peaks. The peak radius was 0.5.
comment:15 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
comment:17 Changed 8 years ago by Michael Reuter
- Status changed from verifying to closed
Since I did the original testing, I noticed the issues and can accept the shortcomings for this release.
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7062
