Ticket #6219 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Cannot remove Python unit tests

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

If you remove a python unit test from the relevent CMakeLists.txt and also rm the file then it still appears in the test suite of an incremental build.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Martyn Gigg

Fix FindPyUnitTest to cope with removed tests. Refs #6219

The Python test directory is trashed and completely regenerated to guarantee it is up to date.

Changeset: 1ff8b35c43373f857b735b14815c09a7ce24958b

comment:3 Changed 8 years ago by Martyn Gigg

Include helper code for Python unit tests... Refs #6219.

in an analogous way that it is done with cxxtest_add_test.

Changeset: 25d7b0029d67a61865d4ea2ee6fee0bcd5740e3c

comment:4 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: As a check you can try this -

  • git rm Code/Mantid/Framework/PythonAPI/test/ImportTest.py
  • Build the VanillaPythonTests.py target
  • Check in bin/VanillaPythonTests or bin/[Release|Debug]VanillaPythonTests on windows and see that ImportTest.py & ImportTest.pyc have gone.
  • Remember to do both:
  • git reset HEAD Code/Mantid/Framework/PythonAPI/test/ImportTest.py
  • git checkout -- Code/Mantid/Framework/PythonAPI/test/ImportTest.py

to get the file back.

comment:5 Changed 8 years ago by Martyn Gigg

Fix FindPyUnitTest to cope with removed tests. Refs #6219

The Python test directory is trashed and completely regenerated to guarantee it is up to date.

Changeset: 1ff8b35c43373f857b735b14815c09a7ce24958b

comment:6 Changed 8 years ago by Martyn Gigg

Include helper code for Python unit tests... Refs #6219.

in an analogous way that it is done with cxxtest_add_test.

Changeset: 25d7b0029d67a61865d4ea2ee6fee0bcd5740e3c

comment:7 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:8 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

This was done, but no longer relevant due to splitting the tests.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7065

Note: See TracTickets for help on using tickets.