Ticket #6231 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

IDF: make 'is' type name more consistent

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: minor Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

In IDF we can say that type 'is' something. However, the attribute names a bit inconsistent in that some start with upper case and some don't.

Make this consistent according to:

Detector (or detector)

RectangularDetector (or rectangularDetector, rectangulardetector, or rectangular_detector)

Source (or source)

SamplePos (or samplePos)

ChopperPos (or chopperPos)

that these are allowed as 'is', in accordance with http://www.mantidproject.org/IDF#Special_.3Ctype.3Es

Change History

comment:1 Changed 8 years ago by Anders Markvardsen

Fix to: IDF: make 'is' type name more consistent. re #6231

Changeset: 17f980557a9a4b8309bca4e0c5144c6ae21890ec

comment:2 Changed 8 years ago by Anders Markvardsen

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Anders Markvardsen

Some testing for re #6231

Changeset: 3a4b90bb80a690bfc7ca6a4581e60b49f8b3858d

comment:4 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test simply open any IDF and change e.g. a is="detector" to is="Detector" or the other way around and then test if this modified IDF still loads into MantidPlot (perhaps using LoadEmptyInstrument)

comment:5 Changed 8 years ago by Anders Markvardsen

Fix to: IDF: make 'is' type name more consistent. re #6231

Changeset: 17f980557a9a4b8309bca4e0c5144c6ae21890ec

comment:6 Changed 8 years ago by Anders Markvardsen

Some testing for re #6231

Changeset: 3a4b90bb80a690bfc7ca6a4581e60b49f8b3858d

comment:7 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:8 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

Checked with the HRPD IDF. Changing various tags does not cause a problem with loading.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7077

Note: See TracTickets for help on using tickets.