Ticket #6235 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Support Annotation Packets From Live Stream

Reported by: Ross Miller Owned by: Ross Miller
Priority: major Milestone: Release 2.3.2
Component: Mantid Keywords: PatchCandidate,Released
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

The ADARA SMS will send out Stream Annotation packets which are used to mark significant features of the data stream. Currently, these include pause & resume, scan start & stop and various comments. We should properly handle these cases in the live listener class.

Change History

comment:1 Changed 8 years ago by Ross Miller

Updateing ADARA packet parsing code

This is the latest code from the ADARA repo, including the new stream annotation packet type.

Refs #6235

Changeset: d5de7a2329b84f498a574afc740df05a2314a1f2

comment:2 Changed 8 years ago by Ross Miller

First cut at support for annotation packets.

Live listener now recognizes annotation packets, logs their comments and marker types (at the info level) and updates time series properties for pause/resume and scan index.

Refs #6235

Changeset: 28ede3930ce52d92ccf20f320c47d186ac3ba704

comment:3 Changed 8 years ago by Ross Miller

Fix constructor for BankedEventPkt

Squash bug introduced in previous commit (d5de7a2329b84f498a574afc740df05a2314a1f2)

Refs #6235

Changeset: 67f91e1f16db0f21699ec2b37653c45ad246363a

comment:4 Changed 8 years ago by Ross Miller

Check a property in the user's config file to see if we should...

...filter events from the live stream when the run has been paused. (By default, paused events ARE filtered out.)

Also fix the timestamp values for everything in the sample logs.

Refs #6235

Changeset: 059f85201a4306b008b08f9bc7e8781611e8580a

comment:5 Changed 8 years ago by Ross Miller

  • Status changed from new to accepted

comment:6 Changed 8 years ago by Ross Miller

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 8 years ago by Ross Miller

Referenced the wrong ticket in the git commit message. This changeset belongs to ticket 6259.

Set run_start property using most recent packet's time

When setting the initial value for the run_start property, use the time from the most recently received packet instead of the current system time. (Doesn't matter too much when using actual live data, but when replaying old data it makes a lot more sense.)

Refs #6235

Changeset: 1b75aa688871a3358ae9a19a944d3f2f65f96063

Last edited 8 years ago by Ross Miller (previous) (diff)

comment:8 Changed 8 years ago by Ross Miller

Fix broken windows build (removed instance of struct timespec)

Refs #6235

Changeset: a1e0234fc9ddee48c52a93a1263c46cb4b185273

comment:9 Changed 8 years ago by Ross Miller

Updateing ADARA packet parsing code

This is the latest code from the ADARA repo, including the new stream annotation packet type.

Refs #6235

Changeset: d5de7a2329b84f498a574afc740df05a2314a1f2

comment:10 Changed 8 years ago by Ross Miller

First cut at support for annotation packets.

Live listener now recognizes annotation packets, logs their comments and marker types (at the info level) and updates time series properties for pause/resume and scan index.

Refs #6235

Changeset: 28ede3930ce52d92ccf20f320c47d186ac3ba704

comment:11 Changed 8 years ago by Ross Miller

Fix constructor for BankedEventPkt

Squash bug introduced in previous commit (d5de7a2329b84f498a574afc740df05a2314a1f2)

Refs #6235

Changeset: 67f91e1f16db0f21699ec2b37653c45ad246363a

comment:12 Changed 8 years ago by Ross Miller

Check a property in the user's config file to see if we should...

...filter events from the live stream when the run has been paused. (By default, paused events ARE filtered out.)

Also fix the timestamp values for everything in the sample logs.

Refs #6235

Changeset: 059f85201a4306b008b08f9bc7e8781611e8580a

comment:13 Changed 8 years ago by Ross Miller

Set run_start property using most recent packet's time

When setting the initial value for the run_start property, use the time from the most recently received packet instead of the current system time. (Doesn't matter too much when using actual live data, but when replaying old data it makes a lot more sense.)

Refs #6235

Changeset: 1b75aa688871a3358ae9a19a944d3f2f65f96063

comment:14 Changed 8 years ago by Ross Miller

Fix broken windows build (removed instance of struct timespec)

Refs #6235

Changeset: a1e0234fc9ddee48c52a93a1263c46cb4b185273

comment:15 Changed 8 years ago by Stuart Campbell

  • Keywords PatchCandidate added

comment:16 Changed 8 years ago by Michael Reuter

  • Milestone changed from Release 2.4 to Release 2.3.2

Moved to patch release.

comment:17 Changed 8 years ago by Ross Miller

Updateing ADARA packet parsing code

This is the latest code from the ADARA repo, including the new stream annotation packet type.

Refs #6235 (cherry picked from commit d5de7a2329b84f498a574afc740df05a2314a1f2)

Changeset: 5ee3357875151b4286c935cb4ef773c57b92d731

comment:18 Changed 8 years ago by Ross Miller

First cut at support for annotation packets.

Live listener now recognizes annotation packets, logs their comments and marker types (at the info level) and updates time series properties for pause/resume and scan index.

Refs #6235 (cherry picked from commit 28ede3930ce52d92ccf20f320c47d186ac3ba704)

Changeset: b965b49d18d04a7319e8ac14871e087b93d911f8

comment:19 Changed 8 years ago by Ross Miller

Fix constructor for BankedEventPkt

Squash bug introduced in previous commit (d5de7a2329b84f498a574afc740df05a2314a1f2)

Refs #6235 (cherry picked from commit 67f91e1f16db0f21699ec2b37653c45ad246363a)

Changeset: 04fbcb5c301fad9f86461cda2a2d91e391859092

comment:20 Changed 8 years ago by Ross Miller

Check a property in the user's config file to see if we should...

...filter events from the live stream when the run has been paused. (By default, paused events ARE filtered out.)

Also fix the timestamp values for everything in the sample logs.

Refs #6235 (cherry picked from commit 059f85201a4306b008b08f9bc7e8781611e8580a)

Changeset: 6bbe2bba4795ccb5008756d986f6a3a4bc370669

comment:21 Changed 8 years ago by Ross Miller

Fix broken windows build (removed instance of struct timespec)

Refs #6235 (cherry picked from commit a1e0234fc9ddee48c52a93a1263c46cb4b185273)

Changeset: e5c6208012ee202aa53462750af81e83023c200f

comment:22 Changed 8 years ago by Ross Miller

Set run_start property using most recent packet's time

When setting the initial value for the run_start property, use the time from the most recently received packet instead of the current system time. (Doesn't matter too much when using actual live data, but when replaying old data it makes a lot more sense.)

Refs #6235 (cherry picked from commit 1b75aa688871a3358ae9a19a944d3f2f65f96063)

Changeset: ff0d8635ae69b7002768e6ec8d30309d3a06e017

comment:23 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:24 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

comment:25 Changed 7 years ago by Nick Draper

  • Keywords PatchCandidate,Released added; PatchCandidate removed

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7081

Note: See TracTickets for help on using tickets.