Ticket #6236 (closed: wontfix)

Opened 8 years ago

Last modified 5 years ago

IDF: Removed support for depricated mark-as attribute

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

It is now release 2.4.

In release 2.6 remove support for depricated mark-as attribute (by then users had enough time to see depricated warning)

More specifically in InstrumentDefinitionParser.cpp remove lines:

for backwards compatebility look for "mark-as"

if ( pCompElem->hasAttribute("mark-as")
pLocElem->hasAttribute("mark-as") )

m_instrument->markAsMonitor(detector);

Change History

comment:1 Changed 8 years ago by Anders Markvardsen

  • Status changed from new to verify
  • Resolution set to wontfix

Thinking more about it then regret creating this ticket. Having the depricated warning + keep support for old 'mark-as' is OK. It is only a few lines of code

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:3 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

Agreed. If it is extremely trivial to support then we may as well keep it. The documentation states you should use 'is' so that seems okay.

comment:4 Changed 8 years ago by Martyn Gigg

  • Milestone changed from Release 2.6 to Release 2.4

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7082

Note: See TracTickets for help on using tickets.