Ticket #624 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

GroupDetectors v2 should not leave 'empty' spectra lying around

Reported by: Nick Draper Owned by: Russell Taylor
Priority: minor Milestone: Iteration 19
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

At the moment GroupDetectors leaves empty zeroed spectra in the workspace after it groups the spectra. A version 2 needs to be created that doesn't do this.

However there are several things to be careful of:

  1. Managed workspaces have problems with changing the dimensions of the workspace (although Russell has some ideas of how we can overcome this).
  2. Several algorithms already use GroupDetectors as a child algorithm, we need to ensure that the change does not adversely affect them.

Change History

comment:1 Changed 11 years ago by Nick Draper

  • Owner set to Russell Taylor

Suggestion:

Change away from the in/out workspace to an in and an out. Allow users to specify groups in bulk using a file.

Ideally the algorithm would work with either cal files, or a simpler format of

#udet     group
1           2
2           2
3           1
4           1 

comment:2 Changed 11 years ago by Nick Draper

  • Milestone changed from Iteration 18 to Iteration 19

Moved as part of iteration 18 end

comment:3 Changed 11 years ago by Russell Taylor

  • Status changed from new to assigned

comment:4 Changed 11 years ago by Russell Taylor

(In [2896]) Adding a GroupDetectors version 2. This one doesn't use an InOut workspace and doesn't leave 'empty' spectra lying around afterward. DiffractionFocussing v1 altered to still use GroupDetectors v1. Re #624.

comment:5 Changed 11 years ago by Russell Taylor

  • Status changed from assigned to closed
  • Resolution set to fixed

Part one done (no more empty spectra). To be continued (by implemented the grouping in bulk from a file) in ticket #803...

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 1472

Note: See TracTickets for help on using tickets.