Ticket #6244 (closed: fixed)
Error in GetDetOffsetsMultiPeaks
| Reported by: | Peter Peterson | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.3.2 |
| Component: | Mantid | Keywords: | PatchCandidate,Released |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
The list of banned peaks does not always get reset during the process of banning based on different criteria. Refactor the code so it is done consistently.
This was discovered in production for POWGEN. See the attached screenshot of CalibrateRectangularDetectors to see how to produce the error.
Attachments
Change History
Changed 8 years ago by Peter Peterson
- Attachment Screenshot-CalibrateRectangularDetectors input dialog.png added
comment:1 Changed 8 years ago by Peter Peterson
Refs #6244. Fixing bug caused by a re-used variable.
Changeset: ed889a41d5f1560a790461012bd30cb017c1e143
comment:3 Changed 8 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
comment:4 Changed 8 years ago by Peter Peterson
Refs #6244. Fixing bug caused by a re-used variable.
Changeset: ed889a41d5f1560a790461012bd30cb017c1e143
comment:5 Changed 8 years ago by Michael Reuter
- Milestone changed from Release 2.4 to Release 2.3.2
Moved the patch release.
comment:7 Changed 8 years ago by Peter Peterson
Refs #6244. Fixing bug caused by a re-used variable. (cherry picked from commit ed889a41d5f1560a790461012bd30cb017c1e143)
Changeset: fd94f48bd98722de7e353a044beb7be161554559
comment:8 Changed 8 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:9 Changed 8 years ago by Michael Reuter
- Status changed from verifying to closed
This now works correctly for the given instance.
comment:10 Changed 7 years ago by Nick Draper
- Keywords PatchCandidate,Released added; PatchCandidate removed
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7090
