Ticket #6259 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Fix run_start value for live listener

Reported by: Ross Miller Owned by: Ross Miller
Priority: major Milestone: Release 2.3.2
Component: Mantid Keywords: PatchCandidate,Released
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

LogManager requires that the run_start property exists and has some value. The live listener normally gets this value from the Run Status packet when a new run starts. However, it's possible that we're not in a run currently and thus haven't set the value of run_start.

Change History

comment:1 Changed 8 years ago by Ross Miller

Set the value of run_status during workspace initialization

We use the timestamp from the most recently received packet to set the value of the run_start property when we initialize the workspace. (The property will be overwritten with a proper value once we get a RunStatus packet saying a new run is starting.)

Refs #6259

Changeset: 9d7dc2254401a706ed9865416f9a5d23abb40991

comment:2 Changed 8 years ago by Ross Miller

  • Status changed from new to accepted

comment:3 Changed 8 years ago by Ross Miller

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Ross Miller

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:5 Changed 8 years ago by Ross Miller

  • Status changed from reopened to accepted

comment:6 Changed 8 years ago by Ross Miller

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 8 years ago by Ross Miller

Accidentally had the wrong ticket # in the git commit message. Pasting the commit message here just to keep the track ticket up to date.


Set run_start property using most recent packet's time

When setting the initial value for the run_start property, use the time from the most recently received packet instead of the current system time. (Doesn't matter too much when using actual live data, but when replaying old data it makes a lot more sense.)

Refs #6235

Changeset: 1b75aa688871a3358ae9a19a944d3f2f65f96063

comment:8 Changed 8 years ago by Ross Miller

Set the value of run_status during workspace initialization

We use the timestamp from the most recently received packet to set the value of the run_start property when we initialize the workspace. (The property will be overwritten with a proper value once we get a RunStatus packet saying a new run is starting.)

Refs #6259

Changeset: 9d7dc2254401a706ed9865416f9a5d23abb40991

comment:9 Changed 8 years ago by Stuart Campbell

  • Keywords PatchCandidate added

comment:10 Changed 8 years ago by Michael Reuter

  • Milestone changed from Release 2.4 to Release 2.3.2

Moved to patch release.

comment:11 Changed 8 years ago by Michael Reuter

This ticket has been cherry picked.

comment:12 Changed 8 years ago by Ross Miller

Set the value of run_status during workspace initialization

We use the timestamp from the most recently received packet to set the value of the run_start property when we initialize the workspace. (The property will be overwritten with a proper value once we get a RunStatus packet saying a new run is starting.)

Refs #6259 (cherry picked from commit 9d7dc2254401a706ed9865416f9a5d23abb40991)

Changeset: d80db0e8c9a21cd37f2350884dec53868206bc02

comment:13 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:14 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

comment:15 Changed 7 years ago by Nick Draper

  • Keywords PatchCandidate,Released added; PatchCandidate removed

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7105

Note: See TracTickets for help on using tickets.