Ticket #6266 (closed: fixed)
Test Class Duplication (PeakOverlays on SliceViewer)
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Stuart Campbell |
Description
Quite a few of the mock classes that I've introduced into SliceViewerTest duplicate mock classes, which are identical to those in other tests.
Would be much better to have them defined once, and commonly assessable.
Change History
comment:2 Changed 8 years ago by Owen Arnold
refs #6266. Consolidate mocking.
Changeset: 145e1a6e7bdb62d5eae5406107f8763b440e4c8a
comment:3 Changed 8 years ago by Owen Arnold
refs #6266. Consolidate mocking.
Changeset: 145e1a6e7bdb62d5eae5406107f8763b440e4c8a
comment:4 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Tester: This is purely a refactoring requirement to avoid duplication of the Mock types required by the tests. A new header has been added, which includes all those Mock types which are commonly used, and have implementations that are not strongly tied to the tests they are working with.
- Check the code changes via inspection
- Run the unit tests
comment:5 Changed 8 years ago by Owen Arnold
refs #6266. Consolidate mocking.
Changeset: 145e1a6e7bdb62d5eae5406107f8763b440e4c8a
comment:6 Changed 8 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
