Ticket #6277 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Add system tests for extensive testing for SCD peak indexing

Reported by: Ruth Mikkelson Owned by: Ruth Mikkelson
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

Thousands of test cases with known result are generated. The FindUBUsingFFT and SelectCellOfType algorithm results are checked with known results.

Change History

comment:1 Changed 8 years ago by Ruth Mikkelson

  • Owner set to Ruth Mikkelson
  • Status changed from new to accepted

comment:2 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Extensive tests for Peak to Conventional cell algorithms

Not done but "Close". Should not run

Changeset: e6f205c18359c13cd6238de0cb28abd9bf50c9fc

comment:3 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Eliminated problems causing some tests to fail

Through a lot of cases, but more need to be checked

Changeset: 61f52a0767c0211f2c3e08cfb5d4bbbada49c6ef

comment:4 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Fixed a few more errors

Finished Monoclinic cases.

Changeset: 973d717b65aed39e0d69219cb794fd20feb765d7

comment:5 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Improved. Eliminated a most tests that didn't work

So far all for Error=0 and Error=.05

Changeset: c8e0e08b19a5c563846f7ca84f3a4904026d2449

comment:6 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

Only test cases for errors =0 and .05 were run. Cases that did not work were specifically removed.

comment:7 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:8 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This test fails for me:

FindUBUsingFFT-[Error] Error in execution of algorithm FindUBUsingFFT:
FindUBUsingFFT-[Error] Find_UB(): Could not find any a,b,c vectors to index Qs
[2.0, 2.3999999999999999, 2.3999999999999999, 90.0, 90.0, 90.0]
[1.999897787968822, 2.399773046520473, 2.4000419307757901, 90.002442658531407, 90.002463575488164, 90.002488046330669]
['Formnum,Lat1,Lat0', 11, [1.9998977879688222, 2.3997730465204721, 2.4000419307757901, 90.002442658531407, 90.002463575488164, 90.002488046330669], [2.0, 2.3999999999999999, 2.3999999999999999, 90.0, 90.0, 90.0]]
=============================================================
[[2, 2.3999999999999999, 2.3999999999999999], 0.050000000000000003, 'O', 'I', 20, 0, 1]
['UBnig', matrix([[ -7.37257477e-18,  -5.00000000e-01,  -5.00000000e-01],
        [  4.16666667e-01,   4.16666667e-01,   0.00000000e+00],
        [  4.16666667e-01,   0.00000000e+00,   4.16666667e-01]]), [1.9697715603592207, 1.969771560359221, 1.969771560359221, 118.98208226759439, 104.9355270538135, 104.9355270538135]]
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/vel/SysTests/StressTestFramework/stresstesting.py", line 168, in execute
    self.runTest()
  File "/home/vel/SysTests/SystemTests/AnalysisTests/Peak2ConvCell_Test.py", line 1172, in runTest
    FindUBUsingFFT(Peaks,Lat0[0]*.5,Lat0[2]*2,.15)
  File "/home/vel/release-testing/Code/release/bin/mantid/simpleapi.py", line 489, in algorithm_wrapper
    algm.execute()
ValueError: Find_UB(): Could not find any a,b,c vectors to index Qs


FAILED:
Peak2ConvCell_Test.Peak2ConvCell_Test

comment:9 Changed 8 years ago by Ruth Mikkelson

  • Milestone changed from Release 2.4 to Release 2.5

comment:10 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Tested with new FindUBUsingFFT

Changeset: 5dd237477558e750802493861244066b4badeada

comment:11 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Tested with new FindUBUsingFFT

Changeset: 5dd237477558e750802493861244066b4badeada

comment:12 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Eliminated test by eliminating superclass

Changeset: 4ccbe9db4c762c2fe8432146ac98819cf1571750

comment:13 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Eliminated test by eliminating superclass

Changeset: 4ccbe9db4c762c2fe8432146ac98819cf1571750

comment:14 Changed 8 years ago by Ruth Mikkelson

  • Status changed from reopened to accepted

comment:15 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Tested with new FindUBUsingFFT

Changeset: 5dd237477558e750802493861244066b4badeada

comment:17 Changed 8 years ago by Ruth Mikkelson

Refs #6277 Eliminated test by eliminating superclass

Changeset: 4ccbe9db4c762c2fe8432146ac98819cf1571750

comment:18 Changed 8 years ago by Vickie Lynch

  • Status changed from verify to verifying

comment:19 Changed 8 years ago by Vickie Lynch

  • Status changed from verifying to closed

Test passes on my RHEL6 machine.

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7123

Note: See TracTickets for help on using tickets.