Ticket #6292 (closed: fixed)
Solve huge memory usage of Instrument view for MAPS and other instruments
Reported by: | Nick Draper | Owned by: | Roman Tolchenov |
---|---|---|---|
Priority: | blocker | Milestone: | Release 2.3.2 |
Component: | MantidPlot | Keywords: | PatchCandidate,Released |
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
MAPS and other instruments that use structured detector ids use a huge amount of memory in the instrument view. A cache is allocation a linear size of the detector number and not taking into account the sparse nature.
This needs to be changed to a map.
Change History
comment:2 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.4 to Release 2.3.2
moved to patch release
comment:3 Changed 8 years ago by Roman Tolchenov
Re #6292. Change the index vector to a map
Changeset: d2a0c2243ee70573bf3a66f56594faf12ccad2c8
comment:4 Changed 8 years ago by Roman Tolchenov
Re #6292. Fixing the test
Changeset: 9a4a25b441ad49ee56c372bf09337dd65d864364
comment:5 Changed 8 years ago by Roman Tolchenov
Re #6292. Fixing the test
Changeset: 547756e93c0fa820fd05fa017bee58dab7415dac
comment:6 Changed 8 years ago by Roman Tolchenov
- Status changed from accepted to verify
- Resolution set to fixed
comment:7 Changed 8 years ago by Michael Reuter
- Status changed from verify to reopened
- Resolution fixed deleted
This does not cherry-pick at all. The InstrumentWindowPickTab.cpp change is in a function that is not in the header and I can't tell at all if that is the only thing that might be wrong. Roman, you'll have to cherry-pick this and make the appropriate fixes to the release-testing branch.
comment:8 Changed 8 years ago by Roman Tolchenov
Re #6292. Repeating the change on the release branch
Changeset: 6e8f17babd404125336f353f59e1038eccb2bb0c
comment:10 Changed 8 years ago by Roman Tolchenov
- Status changed from accepted to verify
- Resolution set to fixed
comment:11 Changed 8 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:12 Changed 8 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
Reopening to submit a partial fix to a memory leak issue.
comment:13 Changed 8 years ago by Roman Tolchenov
Re #6292. QObject holding instrument wasn't deleted
Changeset: b58b9792f41dbcfb88a6f61a0a645a5b69298576
comment:15 Changed 8 years ago by Roman Tolchenov
- Status changed from accepted to verify
- Resolution set to fixed
comment:16 Changed 8 years ago by Martyn Gigg
Fix a small mem leak in InstrumentActor. Refs #6292
The det ID to WS index map was not being deleted.
Changeset: 09d582b9b563fe424f98be806840519342eee153
comment:17 Changed 8 years ago by Roman Tolchenov
Re #6292. QObject holding instrument wasn't deleted (cherry picked from commit b58b9792f41dbcfb88a6f61a0a645a5b69298576)
Changeset: ce95d062b4739f87bb76b7f2c69d51269b4e292e
comment:18 Changed 8 years ago by Martyn Gigg
Fix a small mem leak in InstrumentActor. Refs #6292
The det ID to WS index map was not being deleted. (cherry picked from commit 09d582b9b563fe424f98be806840519342eee153)
Changeset: ecdc82eb92ff7911449b3f43e07a3e39f6ea7932
comment:19 Changed 8 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester changed from Nick Draper to Martyn Gigg
comment:20 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to closed
The memory usage seems acceptable and is freed to a level that is no worse than the last release from whay I can see.
comment:21 Changed 8 years ago by Roman Tolchenov
Re #6292. Change the index vector to a map
Changeset: 170a07369e96b6e61adaeb71e723d283ecbf2d5c
comment:22 Changed 8 years ago by Roman Tolchenov
Re #6292. Fixing the test
Changeset: 20659fb227e388c7457d62fd548f4d88ef483fd3
comment:23 Changed 8 years ago by Roman Tolchenov
Re #6292. Fixing the test
Changeset: c0562bee5ae011db2e4dd86b0c9f2fc5c4e2ef5b
comment:24 Changed 8 years ago by Roman Tolchenov
Re #6292. QObject holding instrument wasn't deleted
Changeset: f635770f2562aa5b3faea258619ee6835dafd908
comment:25 Changed 8 years ago by Martyn Gigg
Fix a small mem leak in InstrumentActor. Refs #6292
The det ID to WS index map was not being deleted.
Changeset: 9fe8c16ea88d28b553644e84eae4575e6487b704
comment:26 Changed 7 years ago by Nick Draper
- Keywords PatchCandidate,Released added; PatchCandidate removed
comment:27 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7138