Ticket #6304 (assigned)

Opened 8 years ago

Last modified 5 years ago

FindPeaksMD should apply some validity check to the peaks returned.

Reported by: Dennis Mikkelson Owned by: Peter Peterson
Priority: major Milestone: Backlog
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester:


Currently, FindPeaksMD always returns the number of peaks requested. Since the peaks are found and returned in order of decreasing magnitude, if the user requests too many peaks, the list will include many false "noise" peaks at the end of the list. This also seriously impacts the execution time, since many lower intensity boxes must be checked to find those that are far enough away from previously found peaks.

Some possible validity checks (in order of increasing difficulty) include:

  1. The peak intensity should be above a minimum threshold specified by the user.
  1. The total intensity inside the peak region should be at least some multiple of the average background noise.
  1. The net integrated intensity of the peak divided by its estimated standard deviation should be above a minimum theshold (eg. 3).

It should work to add an option to FindPeaksMD, such as "Check Validity". If this option is selected, the algorithm could initially find the peaks in the same way it currently does, but then discard any peak not passing the validity check(s).

Change History

comment:1 Changed 8 years ago by Peter Peterson

  • Milestone changed from Release 2.4 to Release 2.5

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:3 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:4 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7150

Note: See TracTickets for help on using tickets.