Ticket #6309 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

FileFinder takes an unacceptably long time to fail with the archive search on

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

To reproduce (an ISIS example):

  • Go to File->Manage User Directories and make sure archive search is checked
  • Click the Load button
  • Clear the filename field and type CSP90004 and press tab (or make the field lose focus so it starts to try and find the file)
  • Go and have a cup of tea (it takes ~3-4 mins to fail!)

It also then locks up for future searches.

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Owner set to Martyn Gigg
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from assigned to accepted

comment:3 Changed 8 years ago by Martyn Gigg

ISISDataArchive uses HTTP status code for errors. Refs #6309

Changeset: 5f76efda041ecacb4255f25be5521bcfa8ac0150

comment:4 Changed 8 years ago by Martyn Gigg

Allow custom dialogs to turn off automatic property parsing on init.

Refs #6309. This prevents multiple setting of properties which can be problematic for properties that take some time when setting values i.e. file searching.

Changeset: 2a922721718f85fc18e22090ce100f2a48cc0b57

comment:5 Changed 8 years ago by Martyn Gigg

Prevent LoadDialog from searching again when run is clicked...

Refs #6309. The dialog now uses the full string as found by the widget rather than the box text to prevent another search when run is clicked and the property is reset.

Changeset: 5004376de56972faaf97344152ae1bc57af2c51a

comment:6 Changed 8 years ago by Martyn Gigg

Include header for linux builds. Refs #6309

Changeset: 0ae387b5c0bac5583d240e87e60e49809f449eeb

comment:7 Changed 8 years ago by Martyn Gigg

Reduce number of duplicate calls to archive search. Refs #6309

Changeset: 23e554e9cddb9751a2526286d3b6a5f827fe32bb

comment:8 Changed 8 years ago by Martyn Gigg

FileFinder on Unix is case-sensitive by default. Refs #6309

It reduces the number of calls to the archive by a considerable number and until an adequate design for FileFinder is here then for the failure cases this avoids it taking minutes to decide that it hasn't found anything (with archive searching on).

Changeset: d119bc9ef9145ca3fa852fbd9e17aa265d699342

comment:9 Changed 8 years ago by Martyn Gigg

FileFinder on Unix is case-sensitive by default. Refs #6309

It reduces the number of calls to the archive by a considerable number and until an adequate design for FileFinder is here then for the failure cases this avoids it taking minutes to decide that it hasn't found anything (with archive searching on).

Changeset: 538004e6cfccbed189d2c513ccbd3b6d793642d8

comment:10 Changed 8 years ago by Martyn Gigg

FileFinder on Unix is case-sensitive by default. Refs #6309

It reduces the number of calls to the archive by a considerable number and until an adequate design for FileFinder is here then for the failure cases this avoids it taking minutes to decide that it hasn't found anything (with archive searching on).

Changeset: c67a214432cca21557ab2dd758f612711ed593f2

comment:11 Changed 8 years ago by Martyn Gigg

Fix test on Unix. Refs #6309

Changeset: d54b590038fa8f0ebe21990bf89209c9755b1dcb

comment:12 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:13 Changed 8 years ago by Martyn Gigg

Tester: This is by no means perfect but it should have reduced the amount of time to wait and things shouldn't lock up.

comment:14 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:15 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to closed

The time really was reduced. I believe it used to take about 5 seconds.

But, there are still some lock ups. To reproduce:

1 ) Load->Files

2 ) Write File = CSP900005

3 ) With the mouse, click on OutputWorkspace

4 ) Click again at File, and edit it to be CSP900004

5 ) With the mouse, double-click on OuptutWorkspace (it will lock up for 10 secconds)

6 ) Click on Cancel and go again to Load->Files ( it will lock up for 10 secconds)

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7155

Note: See TracTickets for help on using tickets.