Ticket #6318 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create ResampleX Algorithm - (originally named RebinRagged)

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

In support of the diffraction instruments (specifically NOMAD) add an algorithm similar to Rebin, but allowing the individual spectra to have different xmin and xmax. This will have to accommodate the fact that mantid workspaces need to have the same number of bins in each spectrum. The specifically requested case is to specify a separate xmin and xmax, with a common number of (logarithmic) bins.

Change History

comment:1 Changed 8 years ago by Peter Peterson

Re #6318. 'class_maker' generated RebinRagged that compiles.

Changeset: 0b4c63e8d291f22b49ac15a3765335107be4fc4f

comment:2 Changed 8 years ago by Peter Peterson

Re #6318. First version that only works with events.

The test doesn't compile (and isn't committed) and handing this a histogram workspace will throw an exception.

Changeset: 754adcdb5ac8c2b7f5e8cb1e61fcf0a71a65d8b6

comment:3 Changed 8 years ago by Peter Peterson

Re #6318. Added unit test for linear binning of a histogram.

Rather than testing the algorithm as a whole, exposed some of the internal functions to test directly.

Changeset: e019bee847cee667e09ad4e910cd4ee648db3504

comment:4 Changed 8 years ago by Peter Peterson

Re #6318. Filled in more features of log resampling.

Some quick checks to make sure that the end values aren't zero because log(0) is undefined, and something to shift the final bin boundary to be xmax.

Changeset: 0713c38225a03590d7f0581b2798ee617f582b8d

comment:5 Changed 8 years ago by Peter Peterson

Re #6318. Added working test for log resampling.

Changeset: e944ad9b729c85d76cb5ab48ccc71749657c1535

comment:6 Changed 8 years ago by Peter Peterson

Re #6318. Added test for linear binning of a density.

Fixed the code to make the test pass. Isn't agile programming awesome!

Changeset: 7b78061dfa7a942e36093e98706b88a199782cca

comment:7 Changed 8 years ago by Peter Peterson

Re #6318. Adding a test to RebinRagged for log binning of density.

Changeset: d9ee8403c9dec746c5370f51f5a66bb2db215068

comment:8 Changed 8 years ago by Peter Peterson

Re #6318. Adding doxygen comments to RebinRagged.

Changeset: 298c11b8fdf65b1456344520359fdce683baefcc

comment:9 Changed 8 years ago by Peter Peterson

Re #6318. Renming RebinRagged to ResampleX.

Changeset: 5a8de97ce9db4bf7cdb4b5169252056a134b6d3f

comment:10 Changed 8 years ago by Peter Peterson

Re #6318. Finished renaming to ResampleX and made it histogram aware.

Changeset: 84d97d92bdf2591ba538e34d8c53e49144b42a39

comment:11 Changed 8 years ago by Peter Peterson

Re #6318. Overriding parent algorithm's alias method to fix the build

Changeset: 99df880055c14a4baacf591a2a663b8986a29012

comment:12 Changed 8 years ago by Peter Peterson

  • Status changed from new to accepted

comment:13 Changed 8 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 8 years ago by Peter Peterson

Re #6318. 'class_maker' generated RebinRagged that compiles.

Changeset: 0b4c63e8d291f22b49ac15a3765335107be4fc4f

comment:15 Changed 8 years ago by Peter Peterson

Re #6318. First version that only works with events.

The test doesn't compile (and isn't committed) and handing this a histogram workspace will throw an exception.

Changeset: 754adcdb5ac8c2b7f5e8cb1e61fcf0a71a65d8b6

comment:16 Changed 8 years ago by Peter Peterson

Re #6318. Added unit test for linear binning of a histogram.

Rather than testing the algorithm as a whole, exposed some of the internal functions to test directly.

Changeset: e019bee847cee667e09ad4e910cd4ee648db3504

comment:17 Changed 8 years ago by Peter Peterson

Re #6318. Filled in more features of log resampling.

Some quick checks to make sure that the end values aren't zero because log(0) is undefined, and something to shift the final bin boundary to be xmax.

Changeset: 0713c38225a03590d7f0581b2798ee617f582b8d

comment:18 Changed 8 years ago by Peter Peterson

Re #6318. Added working test for log resampling.

Changeset: e944ad9b729c85d76cb5ab48ccc71749657c1535

comment:19 Changed 8 years ago by Peter Peterson

Re #6318. Added test for linear binning of a density.

Fixed the code to make the test pass. Isn't agile programming awesome!

Changeset: 7b78061dfa7a942e36093e98706b88a199782cca

comment:20 Changed 8 years ago by Peter Peterson

Re #6318. Adding a test to RebinRagged for log binning of density.

Changeset: d9ee8403c9dec746c5370f51f5a66bb2db215068

comment:21 Changed 8 years ago by Peter Peterson

Re #6318. Adding doxygen comments to RebinRagged.

Changeset: 298c11b8fdf65b1456344520359fdce683baefcc

comment:22 Changed 8 years ago by Peter Peterson

Re #6318. Renming RebinRagged to ResampleX.

Changeset: 5a8de97ce9db4bf7cdb4b5169252056a134b6d3f

comment:23 Changed 8 years ago by Peter Peterson

Re #6318. Finished renaming to ResampleX and made it histogram aware.

Changeset: 84d97d92bdf2591ba538e34d8c53e49144b42a39

comment:24 Changed 8 years ago by Peter Peterson

Re #6318. Overriding parent algorithm's alias method to fix the build

Changeset: 99df880055c14a4baacf591a2a663b8986a29012

comment:25 Changed 8 years ago by Peter Peterson

Re #6318. 'class_maker' generated RebinRagged that compiles.

Changeset: 54b3ca460171a824ef4fcbc95bc26aba08799e93

comment:26 Changed 8 years ago by Peter Peterson

Re #6318. First version that only works with events.

The test doesn't compile (and isn't committed) and handing this a histogram workspace will throw an exception.

Changeset: 7966ddf8c48a4e98b7fd38d96f28d85d0a9eb241

comment:27 Changed 8 years ago by Peter Peterson

Re #6318. Added unit test for linear binning of a histogram.

Rather than testing the algorithm as a whole, exposed some of the internal functions to test directly.

Changeset: 48fb17d790b18fcb21d3aae3b7eac222e76da8a9

comment:28 Changed 8 years ago by Peter Peterson

Re #6318. Filled in more features of log resampling.

Some quick checks to make sure that the end values aren't zero because log(0) is undefined, and something to shift the final bin boundary to be xmax.

Changeset: 4cab06e6096594053cf577d3e9b4c72eeec80245

comment:29 Changed 8 years ago by Peter Peterson

Re #6318. Added working test for log resampling.

Changeset: beb6e0b4f2883b13190a924b4f1d111b05db9778

comment:30 Changed 8 years ago by Peter Peterson

Re #6318. Added test for linear binning of a density.

Fixed the code to make the test pass. Isn't agile programming awesome!

Changeset: 20304a8543206d2050bc59a53c5921955d69129e

comment:31 Changed 8 years ago by Peter Peterson

Re #6318. Adding a test to RebinRagged for log binning of density.

Changeset: d25433d25a8643cabb8c6cfe89472606b5dfd464

comment:32 Changed 8 years ago by Peter Peterson

Re #6318. Adding doxygen comments to RebinRagged.

Changeset: 6d7edacc231b19c87a8503f7e6a94cd74edb63f8

comment:33 Changed 8 years ago by Peter Peterson

Re #6318. Renming RebinRagged to ResampleX.

Changeset: 3e6af85459ec594ebff0ee506dd0a13fad1ad2e4

comment:34 Changed 8 years ago by Peter Peterson

Re #6318. Finished renaming to ResampleX and made it histogram aware.

Changeset: 71d3beb08b72ab36cb5a56cb1cba23fa470ea963

comment:35 Changed 8 years ago by Peter Peterson

Re #6318. Overriding parent algorithm's alias method to fix the build

Changeset: 206ce76f1f38bbcf15a96409c52fb6d19d26f26b

comment:36 Changed 8 years ago by Stuart Campbell

  • Summary changed from RebinRagged to Create ResampleX Algorithm - (originally named RebinRagged)

comment:37 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:38 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to reopened
  • Resolution fixed deleted

There is no wiki page for neither "RebinRagged" nor "ResampleX".

comment:39 Changed 8 years ago by Peter Peterson

  • Status changed from reopened to accepted

comment:40 Changed 8 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

There is a wiki page now http://www.mantidproject.org/ResampleX

comment:41 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying

comment:42 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:43 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7164

Note: See TracTickets for help on using tickets.