Ticket #6321 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

FileFinder search at SNS defect

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: blocker Milestone: Release 2.3.2
Component: Mantid Keywords:
Cc: rens@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

Filenames like NOM_9334_event.nxs do not work with the current FileFinder. Modify FileFinder until the following "hints" work:

  • PG31234
  • PG3_1234
  • PG3_1234_event.nxs
  • REF_L1234
  • REF_L_1234
  • REF_L_1234.nxs.h5

Change History

comment:1 Changed 8 years ago by Peter Peterson

  • Status changed from new to accepted
  • Cc rens@… added

comment:2 Changed 8 years ago by Peter Peterson

Re #6321. Refactor filefinder to give Instrument to makdeFileName.

Since the code that calls makeFileName has the instrument, just pass that along and call it a day. This will look like a lot more changes than it really is because of this refactoring.

Changeset: 36831ec12781c3a02e8b3ead3b3f4087cf47f7f8

comment:3 Changed 8 years ago by Peter Peterson

Re #6321. Refactor filefinder to give Instrument to makdeFileName.

Since the code that calls makeFileName has the instrument, just pass that along and call it a day. This will look like a lot more changes than it really is because of this refactoring.

Changeset: b40dd61be64c6f47477be391b2cc5a27cdd137aa

comment:4 Changed 8 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

Everything appears to work (the builds are fine).

comment:5 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 8 years ago by Martyn Gigg

Finding still looks okay for simple prefixes as well as ones containing underscores etc.

comment:7 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:8 Changed 8 years ago by Peter Peterson

Re #6321. Refactor filefinder to give Instrument to makdeFileName.

Since the code that calls makeFileName has the instrument, just pass that along and call it a day. This will look like a lot more changes than it really is because of this refactoring.

Changeset: ed7d5ca4b06782b4a88889c5e32c95706cc2d226

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7167

Note: See TracTickets for help on using tickets.