Ticket #6323 (closed: fixed)
Fix threading bug in FermiChopperModel
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description
The TobyFitResolution system tests fails occasionally with this error:
ResolutionConvolvedCrossSection-[Error] ResolutionConvolvedCrossSection: FermiChopperModel::regimeFactor - gamma is greater than 4! Behaviour is undefined. Value=inf
ResolutionConvolvedCrossSection-[Error] Component values: chopper radius=0.049,deltaT=6.22545e-06,slitRadius=1.3,Ei=0,omega=3769.91,slitThickness=0.0023
The Ei value should be 300 so there is a threading issue when the FermiChopperModel retrieves the Ei.
Change History
comment:2 Changed 8 years ago by Martyn Gigg
Fix thread-safety issue in Cache class Refs #6323
The Cache class was not fully threadsafe. The PARALLEL sections have been replaced by a per-object FastMutex to ensure thread safety. Hopefully this won't have a huge effect on performance.
Changeset: 64d4e11e837adf99eca6c78a7f45150afcefea97
comment:3 Changed 8 years ago by Martyn Gigg
Fix return statment in coy constructor. Refs #6323
gcc let me get away with that for some reason...
Changeset: 150b9c740b7c87482b04b0d72e1f84dc2958f7c2
comment:4 Changed 8 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:5 Changed 8 years ago by Martyn Gigg
Fix thread-safety issue in Cache class Refs #6323
The Cache class was not fully threadsafe. The PARALLEL sections have been replaced by a per-object FastMutex to ensure thread safety. Hopefully this won't have a huge effect on performance.
Changeset: 2fb3881c20311ba52af65d77b8fef712f20c2661
comment:6 Changed 8 years ago by Martyn Gigg
Fix return statment in coy constructor. Refs #6323
gcc let me get away with that for some reason...
Changeset: 2f5b378603351f9f0eaaf037a1f42be96fea121b
