Ticket #6326 (closed: fixed)
Minor changes to SNSLiveEventDataListener
Reported by: | Ross Miller | Owned by: | Ross Miller |
---|---|---|---|
Priority: | major | Milestone: | Release 2.4 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Stuart Campbell |
Description
Various & sundry changes to the live listener (mostly bug fixes)
Change History
comment:2 Changed 8 years ago by Ross Miller
Sleep briefly after calling read() if there's no data to process
Keeps us from thrashing in a tight loop when there's no incoming data.
Refs #6326
Changeset: 8487f4c070d4f8c259a0360c2426cc89291cb2f7
comment:3 Changed 8 years ago by Ross Miller
Minor changes to SNSLiveEventDataListener
A few minor changes: 1) Add some more exception handling code to the ::run() function. (Still can do anything more than log error messages if the background thread throws an exception, but the error messages are a little more detailed now.)
2) Changed all the packet handler functions to return false. In the context of ADARA, false means "No errors, keep parsing the input data".
3) in initWorkspace(), check for the existence of the run_start property before attempting to create it. It's possible to receive a RunStatus packet before initWorkspace is called. In that case, we'll already have a run_start property and trying to create another causes problems.
refs #6326
Changeset: 7ffbb84951c67e71e3af4a9325d3cf01ac666cdf
comment:4 Changed 8 years ago by Ross Miller
Sleep briefly after calling read() if there's no data to process
Keeps us from thrashing in a tight loop when there's no incoming data.
Refs #6326
Changeset: 9c9f4c81d8e5f9a02eb55e152ac002c321f34e84
comment:6 Changed 8 years ago by Ross Miller
- Status changed from accepted to verify
- Resolution set to fixed
comment:7 Changed 8 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
Minor changes to SNSLiveEventDataListener
A few minor changes: 1) Add some more exception handling code to the ::run() function. (Still can do anything more than log error messages if the background thread throws an exception, but the error messages are a little more detailed now.)
2) Changed all the packet handler functions to return false. In the context of ADARA, false means "No errors, keep parsing the input data".
3) in initWorkspace(), check for the existence of the run_start property before attempting to create it. It's possible to receive a RunStatus packet before initWorkspace is called. In that case, we'll already have a run_start property and trying to create another causes problems.
refs #6326