Ticket #6328 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Migration script enhancements

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description (last modified by Martyn Gigg) (diff)

Various improvements:

  • Migration script should not put stuff on LHS in new algs: 
    The migration scripts currently try to be clever & pull variables to the LHS. There are circumstances where this is not what you want to do so lets be conservative and just change them to take all keywords
  • Functions with lists/tuples are not migrated correctly at the moment. The AST parser needs to do a better job here

Change History

comment:1 Changed 8 years ago by Martyn Gigg

Begin switching to ast parsing rather. Refs #6328

Changeset: dd5ad4e76af928e876e7f117a63e5d03440b3e0f

comment:2 Changed 8 years ago by Martyn Gigg

  • Milestone changed from Release 2.4 to Release 2.5

comment:3 Changed 8 years ago by Martyn Gigg

Begin switching to ast parsing rather. Refs #6328

Changeset: 0a3ec8f865074dbe8c2c781df6b1840b50d93649

comment:4 Changed 8 years ago by Martyn Gigg

Don't put things on LHS. Refs #6328

Changeset: fec76ff30fa58229c6c743ed882e53502eea791b

comment:5 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted
  • Description modified (diff)
  • Summary changed from Improve migration scripts to Migration script should not put stuff on LHS in new algs

comment:6 Changed 8 years ago by Martyn Gigg

Begin switching to ast parsing rather. Refs #6328

Changeset: 00d6c1f661b2666853573582b4d5b6811f890b55

comment:7 Changed 8 years ago by Martyn Gigg

Don't put things on LHS during script migration. Refs #6328

Changeset: ed1768743487c4858baa6304fabed821e80ed65f

comment:8 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:10 Changed 8 years ago by Martyn Gigg

Do a partial migration and save that result. Refs #6328

Changeset: bc39639f4e0a23fae1337ca5f87625c79cc85dd1

comment:11 Changed 8 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:12 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:13 Changed 8 years ago by Martyn Gigg

Recurse directories in migration scripts. Refs #6328

Changeset: fc533213afe948549aab19a528886136d6d6e56b

comment:14 Changed 8 years ago by Martyn Gigg

Improve simple api argument parsing in migration. Refs #6328

It now sees embedded lists, function calls etc properly.

Changeset: 6a12d5a569044ca245c4c2fa9a8d23c738d8fce3

comment:15 Changed 8 years ago by Martyn Gigg

Move message about backup. Refs #6328

Changeset: 1e27a0576dca5012be9b2d58cce8c1484c3e470f

comment:16 Changed 8 years ago by Martyn Gigg

Add other log message levels to migration tool. Refs #6328

Changeset: 07c494ca82c40670fed01d4f97a93556a10fb939

comment:17 Changed 8 years ago by Martyn Gigg

  • Priority changed from major to critical
  • Description modified (diff)
  • Summary changed from Migration script should not put stuff on LHS in new algs to Migration script enhancements

comment:18 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:19 Changed 8 years ago by Owen Arnold

Looks good. Fed in this to migrate1to2.py 

from mantidsimple import *
CreateSingleValuedWorkspace('x', 2, 2)

And got this 

from mantid.simpleapi import *
CreateSingleValuedWorkspace(OutputWorkspace='x',DataValue= 2,ErrorValue= 2)

comment:20 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7174

Note: See TracTickets for help on using tickets.