Ticket #632 (closed: wontfix)

Opened 11 years ago

Last modified 5 years ago

Make sure all algorithms propagate masking correctly

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 2.2
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

For many, this will come for free because the masking will be copied into a workspace created from a parent of the same size. The following algorithms have already been explicitly changed to propagate any masks (this should mean that all those used in a diffraction focussing analysis take account of this):

  • ConjoinWorkspaces
  • CropWorkspace
  • DiffractionFocussing2
  • MaskBins
  • Rebin
  • Unwrap

See attached spreadsheet for more details

Attachments

AlgsMasking.xlsx​ (13.2 KB) - added by Russell Taylor 11 years ago.

Change History

Changed 11 years ago by Russell Taylor

comment:1 Changed 11 years ago by Nick Draper

  • Milestone changed from Iteration 18 to Iteration 19

Moved as part of iteration 18 end

comment:2 Changed 11 years ago by Nick Draper

  • Priority changed from major to minor

comment:3 Changed 11 years ago by Nick Draper

  • Milestone changed from Iteration 19 to Iteration 20

Moved as part of the end of Iteration 19

comment:4 Changed 11 years ago by Russell Taylor

(In [3293]) Add exclusion of any masked bins to the Linear algorithm. Re #632.

comment:5 Changed 11 years ago by Russell Taylor

(In [3295]) Add propagation of masking to BinaryOperation. Also some tidying up while I was there that spidered a small amount. Re #632.

comment:6 Changed 11 years ago by Russell Taylor

(In [3470]) Change the internal storage of the lists of masked bins from a list to a set. Re #632.

comment:7 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:8 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:9 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:10 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:11 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:12 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:13 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:14 Changed 8 years ago by Russell Taylor

  • Status changed from new to verify
  • Component set to Mantid
  • Resolution set to wontfix

This might have been a feasible aspiration 3 years ago, but the number of algorithms we have now, and the number of paths through them, make it unrealistic to trawl through all of them in this fashion.

There are in any case few situations where it will make a difference to have them explicitly masked when the data will have been zeroed in any case. Plus, as noted in the description, if a workspace is created from a parent of the same size the masking will be copied over.

This is about bin masking rather than detector masking, by the way.

comment:15 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:16 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1480

Note: See TracTickets for help on using tickets.