Ticket #6333 (closed: fixed)
The code for MoveInstrument & RotateInstrument needs to be refactored out
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.4 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Karl Palmen |
Description
I had cause to want to move a detector but don't want the overhead of calling an algorithm many times so the code that does this needs to be refactored out. It is currently copied in several places anyway so for that reason alone it should be moved.
Change History
comment:2 Changed 8 years ago by Martyn Gigg
Add a unit test for RotateInstrumentComponent. Refs #6333
One did not exist and this is not good for refactoring work.
Changeset: 9a9ab7a0a9ce2a720d629109f18625b0b59089be
comment:3 Changed 8 years ago by Martyn Gigg
Add a ComponentHelper namespace. Refs #6333
Similar to VectorHelper it contains functions for doing things to components that don't belong on the class itself.
Changeset: 8e36e4bd758baf6d422c6ee577fd65527a365755
comment:4 Changed 8 years ago by Martyn Gigg
Use new component helpers in a few algorithms. Refs #6333
Replaces copy-and-pasted code.
Changeset: ed408067c2b551b261b445185164d3d5e6a4c6bc
comment:5 Changed 8 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:6 Changed 8 years ago by Martyn Gigg
Revert "Use new component helpers in a few algorithms. Refs #6333"
This reverts commit ed408067c2b551b261b445185164d3d5e6a4c6bc and fixes the system tests until further investigation of the failure (and also why the unittests passed!).
Changeset: 21f52c67892f1d27d41a041fed65fd9eb0574e57
comment:7 Changed 8 years ago by Martyn Gigg
Fix issue with setting position of rotated components. Refs #6333
This reverts commit 21f52c67892f1d27d41a041fed65fd9eb0574e57 and fixes it.
Changeset: 85a89e33040b4b2095538ae859dd92fdbce43d09
comment:8 Changed 8 years ago by Martyn Gigg
Use ComponentHelper in LoadDetectorInfo Refs #6333
Changeset: 3236df975d08cbbe02875955c23afe7d9bf8ea42
comment:9 Changed 8 years ago by Martyn Gigg
Add a unit test for RotateInstrumentComponent. Refs #6333
One did not exist and this is not good for refactoring work.
Changeset: 3abc5642eee4723fc16f6d9ddf3eb86429aac889
comment:10 Changed 8 years ago by Martyn Gigg
Add a ComponentHelper namespace. Refs #6333
Similar to VectorHelper it contains functions for doing things to components that don't belong on the class itself.
Changeset: 0bd8b2c0beed7ec841097473a2c29e8d28dff531
comment:11 Changed 8 years ago by Martyn Gigg
Use new component helpers in a few algorithms. Refs #6333
Replaces copy-and-pasted code.
Changeset: c17203d12ebc93f1d6c66ec546a068c518db4307
comment:12 Changed 8 years ago by Martyn Gigg
Revert "Use new component helpers in a few algorithms. Refs #6333"
This reverts commit ed408067c2b551b261b445185164d3d5e6a4c6bc and fixes the system tests until further investigation of the failure (and also why the unittests passed!).
Changeset: b806e619ee43df4dbed5aeface34b6de9dcafa56
comment:13 Changed 8 years ago by Martyn Gigg
Fix issue with setting position of rotated components. Refs #6333
This reverts commit 21f52c67892f1d27d41a041fed65fd9eb0574e57 and fixes it.
Changeset: 129138b50e56c45e3592f7f1559a4e03941e102e
comment:14 Changed 8 years ago by Martyn Gigg
Use ComponentHelper in LoadDetectorInfo Refs #6333
Changeset: 694dbf138a75e87c91231b8ce724bad2ee89551f
comment:15 Changed 8 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:16 Changed 8 years ago by Karl Palmen
- Status changed from verifying to closed
Code show that actual movement and rotation is done by geometry::ComponentHelper rather than directly by the algorithm. Some simple tests of the algorithms work as expected.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7179
