Ticket #6369 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

MWRunFiles sometimes emits the filesFound signal when nothing's been found

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: trivial Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #6371 Tester: Peter Peterson

Description

For example, if the combobox is empty and loses focus, this signal is unnecessarily emitted.

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Russell Taylor

  • Blocking 6314 added

comment:3 Changed 8 years ago by Russell Taylor

  • Blocking 6371 added; 6314 removed

comment:4 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Testing: Not much observable behaviour about the absence of a signal, but before I fixed this if the file box in the Rocking Curve dialog lost focus it would trigger LoadEventNexus with an empty filename - which obviously produced an error. Now it doesn't and it seems unlikely this change should have broken anything - though I only checked the Load dialog.

comment:5 Changed 8 years ago by Russell Taylor

Re #6369. Only emit the filesFound signal if something's been found.

Changeset: 727c85a8a5c49c4840b45b8872db83270765718e

comment:6 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:7 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to closed

Looking at the source this appears to have been fixed.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7215

Note: See TracTickets for help on using tickets.