Ticket #6387 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Cache value of found file in FileProperty

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: minor Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

Since FileFinder gets run several times during an instance of an algorithm's life, cache the result of the found file and file to look for. This should give a perceived speedup in algorithm execution as FileFinder won't be run multiple times with the same input.

Change History

comment:1 Changed 8 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:2 Changed 8 years ago by Peter Peterson

The commit didn't get attached to the ticket ​14b545d53ec5eba3e163c1e800f548c7233970d9

comment:3 Changed 8 years ago by Peter Peterson

Re #6387. Caching values of the loadfile value and found file.

This should just give an effective speedup in algorithm execution time.

Changeset: 14b545d53ec5eba3e163c1e800f548c7233970d9

comment:4 Changed 8 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

To verify that this was done correctly, change the logging level to "information" and look for the string "found path = ..." to occur only once.

comment:5 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:6 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

"found path = ..." does indeed seem to be printed only once (if at all).

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7233

Note: See TracTickets for help on using tickets.