Ticket #6394 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Improve Back2BackExponential fit stability

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Jose Borreguero

Description


Change History

comment:1 Changed 8 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Roman Tolchenov

Re #6394. Removed m_cutOff variable, changed normalization.

At some values of A and B the term with A becomes negligible compared to that with B. The cut-off had an effect of preserving that state: the derivatives with respect to A were always zero.

Changeset: 6f11f6d5e8c201ff4f4d2ad651675e69f1c07ae8

comment:3 Changed 8 years ago by Roman Tolchenov

Re #6394. Recommitting previous changes after strange gti failure.

Changeset: 490bc94d4811cb40d3256319541e820bf832d16b

comment:4 Changed 8 years ago by Roman Tolchenov

Re #6394. Added a unit test for BackToBackExponential.

Changeset: adc0e4e150055a718b48badd49935c9174731ee8

comment:5 Changed 8 years ago by Roman Tolchenov

Re #6394. Fixed broken test.

Changes to BackToBackExponential may affect ticket #6423.

Changeset: 270480b8b1c0bd7c676711b94def632e089d885b

comment:6 Changed 8 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 8 years ago by Jose Borreguero

  • Status changed from verify to verifying
  • Tester set to Jose Borreguero

comment:8 Changed 8 years ago by Jose Borreguero

  • Status changed from verifying to closed

Inclusion of gsl_sf_log_erfc to prevent overflow was a great idea!

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7240

Note: See TracTickets for help on using tickets.