Ticket #64 (closed: fixed)

Opened 13 years ago

Last modified 5 years ago

Intergrate geometry surfaces into Geometry objects

Reported by: Nick Draper Owned by: Russell Taylor
Priority: blocker Milestone: Iteration 10
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Nick Draper) (diff)

This should be used to cover the implementation of the ObjComponent class, and the intergation there of the location and shape geometries

Change History

comment:1 Changed 13 years ago by Nick Draper

  • Summary changed from Intergrate geometry surfaces into Geomerty objects to Intergrate geometry surfaces into Geometry objects

comment:2 Changed 13 years ago by Nick Draper

(In [451]) re #64 Improved windows build of geometry.

Still got two linking errors though

comment:3 Changed 13 years ago by Nick Draper

(In [453]) re #64 Improved windows build of geometry.

Still got one linking error though

comment:4 Changed 13 years ago by Nick Draper

(In [470]) re #64 Improved windows build of geometry.

We are warning free. My lord! that took some brain bending template puzzle solving.

comment:5 Changed 13 years ago by Nick Draper

(In [473]) re #64 Clear final warnings on windows build, mainly in iterator

comment:6 Changed 13 years ago by Nick Draper

(In [565]) re #64 Temporary implmentation for Matrix * Vec3d put in place to allow compiliation

comment:7 Changed 13 years ago by Nick Draper

(In [570]) re #64 Added gsl dll, inc and src for windows builds

comment:8 Changed 13 years ago by Stuart Ansell

(In [575]) Re #64

Merge of V3D with Vec3D. Since Vec3D is a inclusive type

vector (provides all the expected functionality, I am adding Vec3D functions to V3D and then going to replace Vec3D where possible with V3D. Note: that Vec3D acts as a base class to range-bound vectors and geodesic-vectors. Hence the addition of virtual methods.

comment:9 Changed 13 years ago by Stuart Ansell

(In [578]) re #64

Fixed a stupid warning in matrix + a minor error in Faddev routine. Also added the beginnings of a test.[ which needs numerical accuracy test for the TS_ASSERT_EQUALS.

comment:10 Changed 13 years ago by Stuart Ansell

(In [580]) Re #64

Moved Matrix since it is being used.

Matrix is JUNK. You REALLY should not be using it. It is some of the first code I wrote in C++, and is inefficient with poor maths etc. Use something else....

I guess that the interface will hold.

comment:11 Changed 13 years ago by Stuart Ansell

(In [592]) re #64

Modifications to Matrix to avoid a stupid memory leak.

comment:12 Changed 13 years ago by Nick Draper

  • Owner set to Stuart Ansell
  • Milestone changed from Iteration 4 to Iteration 5

comment:13 Changed 13 years ago by Stuart Ansell

(In [602]) re #64

Fixing some doxygen

comment:14 Changed 13 years ago by Stuart Ansell

(In [603]) re #64

Adding the stuff to fix doxygen errors.

comment:15 Changed 13 years ago by Nick Draper

(In [679]) re #64 Error in win version of this code

comment:16 Changed 13 years ago by Nick Draper

  • Owner Stuart Ansell deleted
  • Milestone changed from Iteration 5 to Unassigned

comment:17 Changed 13 years ago by Nick Draper

  • Owner set to Stuart Ansell
  • Milestone changed from Unassigned to Iteration 7

comment:18 Changed 13 years ago by Stuart Ansell

(In [822]) re #64

This is improvements to the polynomial system

comment:19 Changed 13 years ago by Nick Draper

(In [823]) re #64

Corrections for windows. Mainly you cannot have declarations in templated classes without a definition.

comment:20 Changed 13 years ago by Stuart Ansell

(In [824]) #re 64 re #64

Geometry tests

comment:21 Changed 13 years ago by Stuart Ansell

(In [825]) re #64

Added some more tests.

comment:22 Changed 13 years ago by Nick Draper

(In [827]) re #64 fixed the algebra tests, lots more to do

comment:23 Changed 13 years ago by Nick Draper

(In [828]) re #64 Sorted out the wrong case for Acomp.h

comment:24 Changed 13 years ago by Nick Draper

(In [831]) re #64 Improved some more unit tests testObject.h cannot be fixed without input from Stuart, therefore renamed to testObject.hh to avoid auto inclusion. Three test failures remain that need Stuart's attention.

comment:25 Changed 13 years ago by Nick Draper

(In [832]) re #64 Adjust linux build server to update test area of svn

comment:26 Changed 13 years ago by Nick Draper

(In [833]) re #64 Added testSphere.h as an example of what the unit tests for a geometry class should be like. Removed the sphere test from testSurface.h.

comment:27 Changed 13 years ago by Nick Draper

(In [834]) re #64 Added testCylinder.h as an example of what the unit tests for a geometry class should be like. Removed the Cylinder test from testSurface.h.

Some tests fail, although this points to a bug in DistanceTrue so I will leave them in as we need to fix the underlying bug.

comment:28 Changed 13 years ago by Nick Draper

(In [838]) re #64 Corrected bug in TestMatrix and addedd missing template definitions to Matrix.cpp

comment:29 Changed 13 years ago by Nick Draper

(In [840]) re #64 Cleared windows build warnings. Particularly the deprecation ones for the C++ std library.

comment:30 Changed 13 years ago by Nick Draper

(In [841]) re #64 #pragma warning causes a warning in gcc. Also sorted out a gcc warning about an uninitialied enum

comment:31 Changed 13 years ago by Stuart Ansell

(In [843]) #re 64 re #64

Fixing geometry

comment:32 Changed 13 years ago by Nick Draper

(In [844]) re #64 Reinsert scontruct changes overwritten by stuart

comment:33 Changed 13 years ago by Nick Draper

(In [846]) re #64 Removed warning about int operator == by converting to bool operator ==. Also removed one unnecessary std::cout line

comment:34 Changed 13 years ago by Stuart Ansell

(In [847]) re #64 re #63

This change to work Linux, uses -Wl,-rpath so that the LD_LIBRARYPATH does not need to be set. This avoids the need to set it AND overwrite the global value of this variable in the run_tests.sh scritp.

comment:35 Changed 13 years ago by Stuart Ansell

(In [849]) re #64

Test for algebra fixed

comment:36 Changed 13 years ago by Stuart Ansell

(In [850]) re #64

Updates to algebra to make testing easier + some better tests.

Fundermentally, makeDNF + Sort : should get idential results to logicialEqual without the penalty cost. The last test in testDNF is rather interesting but takes a few seconds.

comment:37 Changed 13 years ago by Nick Draper

(In [851]) re #64 sorted out the bad editing of the sconstruct file

comment:38 Changed 13 years ago by Nick Draper

(In [855]) re #64 sorted out bug in re mechanism

comment:39 Changed 13 years ago by Nick Draper

(In [857]) re #64 message formatting

comment:40 Changed 13 years ago by Stuart Ansell

(In [859]) re #64

Upgrade to the surfaces and other objects See the comments in the stuff. Have not fixed all the tests but fixed to compile.

comment:41 Changed 12 years ago by Nick Draper

(In [860]) re #64 message formatting

comment:42 Changed 12 years ago by Nick Draper

(In [863]) re #64 fix doxygen on the windows build server

comment:43 Changed 12 years ago by Nick Draper

(In [864]) re #64 Fix some of the geometry tests, and reinsert some code that was carelessly wiped in an update by an unnamed developer

comment:44 Changed 12 years ago by Nick Draper

(In [866]) re #64 Fix the rest of the geometry tests. Also put back in some more wiped changes

comment:45 Changed 12 years ago by Nick Draper

(In [867]) re #64 Rearrange test file names to match the scheme used in the other projects. i.e. ClassNameTest.h

comment:46 Changed 12 years ago by Stuart Ansell

(In [869]) re #64

Some simple fixes to the test + geometry stuff.

More fixes (bit bigger for MBrect and friends) on the way. But this does not fail any test for geometry objects.

It does not work with existing SConstruct on linux. You need SConstruct from revision 850.

comment:47 Changed 12 years ago by Nick Draper

  • Owner changed from Stuart Ansell to Lakshmi Sastry
  • Description modified (diff)

comment:48 Changed 12 years ago by Nick Draper

  • Milestone changed from Iteration 7 to Iteration 8

comment:49 Changed 12 years ago by Nick Draper

(In [968]) re #64 rename surfaceGeometry to SurfaceGeometry part 1 of 3

comment:50 Changed 12 years ago by Nick Draper

(In [969]) Re #64 Renamed remotely

comment:51 Changed 12 years ago by Nick Draper

(In [970]) re #64 Renamed remotely

comment:52 Changed 12 years ago by Nick Draper

(In [971]) re #64 rename surfaceGeometry to SurfaceGeometry final part

comment:53 Changed 12 years ago by Stuart Ansell

(In [972]) #re 64 re #64

Minor changes to deal with the concept of

Object being sets as Name Material string(Rules)

comment:54 Changed 12 years ago by Nick Draper

(In [973]) re #64 buildable but not finished ObjectTest.h

comment:55 Changed 12 years ago by Nick Draper

(In [974]) re #64 Bug fixes in geometry and more test in ObjectTest.h

comment:56 Changed 12 years ago by Nick Draper

(In [983]) re #64 Bug fixes in geometry and more test in ObjectTest.h

comment:57 Changed 12 years ago by Nick Draper

(In [986]) re #64 Got a / in the #include the wrong way around for Linux

comment:58 Changed 12 years ago by Stuart Ansell

(In [1005]) Re #64

Modifications to get Track to work Track now does not report the void segments. Modified to deal with touching surfaces.

comment:59 Changed 12 years ago by Nick Draper

(In [1010]) re #64 Issue with Track.cpp building on visual studio

comment:60 Changed 12 years ago by Nick Draper

  • Priority changed from major to critical
  • Milestone changed from Iteration 8 to Iteration 9

comment:61 Changed 12 years ago by Nick Draper

  • Priority changed from critical to blocker

comment:62 Changed 12 years ago by Nick Draper

  • Owner changed from Lakshmi Sastry to Russell Taylor

comment:63 Changed 12 years ago by Nick Draper

  • Milestone changed from Iteration 9 to Iteration 10

comment:64 Changed 12 years ago by Russell Taylor

  • Status changed from new to assigned

comment:65 Changed 12 years ago by Russell Taylor

(In [1142]) First steps to implementing ObjComponent. Mainly tidying up. Re #64.

comment:66 Changed 12 years ago by Russell Taylor

(In [1149]) Added a NullPointerException, which is common in other languages. Re #64.

comment:67 Changed 12 years ago by Russell Taylor

(In [1165]) Added methods to ObjComponent to integrate the geometrical object that it holds. Changed Component::getPos because I think it should use the parent's rotation instead of its own (to be checked). Fixed bug in Track::interceptSurface where return was wrong if the track passed in wasn't 'fresh'. Re #64.

comment:68 Changed 12 years ago by Russell Taylor

(In [1166]) Add solidAngle method to ObjComponent. Re #64.

comment:69 Changed 12 years ago by Russell Taylor

(In [1167]) Doxygen. Re #64.

comment:70 Changed 12 years ago by Nick Draper

  • Status changed from assigned to closed
  • Resolution set to fixed

comment:71 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 912

Note: See TracTickets for help on using tickets.