Ticket #6408 (closed: worksforme)

Opened 8 years ago

Last modified 5 years ago

Unscripted testing Group workspaces

Reported by: Nick Draper Owned by: Federico M Pouzols
Priority: blocker Milestone: Release 3.4
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description (last modified by Andrei Savici) (diff)

See the items at the bottom of this page http://www.mantidproject.org/Unscripted_Manual_Testing

Record in the comments what environment was used

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from new to closed
  • Resolution set to fixed

Opened straight to testing with a fake owner, so anyone can test.

comment:2 Changed 8 years ago by Nick Draper

  • Status changed from closed to verify
  • Resolution fixed deleted

comment:3 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:4 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

Used Ubuntu 12.10. Grouped workspaces obtained by LoadSassena, FilterEvents, DGSReduction

comment:5 Changed 7 years ago by Nick Draper

  • Owner Anyone deleted
  • Resolution set to worksforme
  • Tester Andrei Savici deleted
  • Component changed from Mantid to User Interface
  • Milestone changed from Release 2.4 to Release 2.6

Ticket resurrected for R2.6

comment:6 Changed 7 years ago by Nick Draper

  • Owner set to Anyone
  • Status changed from closed to verify
  • Resolution worksforme deleted

comment:7 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Description modified (diff)
  • Tester set to Andrei Savici

comment:8 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Things tested:

  1. Load multiple files as workspace group
  2. LoadSassena (will generate workspace group)
  3. Ungroup/Group workspaces
  4. DgsReduction algorithm runs on all members
  5. SassenaFFT will generate another member in the group
  6. Get handle to the workspace group
  7. FilterEvents will generate group

Things to check next release - ticket #7630. The output from an algorithm w=SomeAlg(WSGroup) contains w_1, w_2, ..., independent of the names of the workspaces in WSGroup. This might get confusing

comment:9 Changed 7 years ago by Nick Draper

  • Status changed from closed to verify

Reopened for testing in Release 3.0

comment:10 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Release 3.0
  • Tester Andrei Savici deleted

comment:11 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.0 to Release 2.6

Unnecessary in this release, was highlighted in R2.6 because some work had gone on during that release.

comment:12 Changed 7 years ago by Nick Draper

  • Status changed from verify to closed
  • Resolution set to fixed

comment:13 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Release 3.3

Reasurrected for R3.3 testing

comment:14 Changed 6 years ago by Nick Draper

  • Status changed from closed to verify
  • Resolution fixed deleted

comment:15 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:16 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to closed

I have reported an issue in Ticket #10728

comment:17 Changed 5 years ago by Owen Arnold

  • Milestone changed from Release 3.3 to Release 3.4

comment:18 Changed 5 years ago by Owen Arnold

  • Status changed from closed to assigned

comment:19 Changed 5 years ago by Federico M Pouzols

  • Owner changed from Anyone to Federico M Pouzols
  • Status changed from assigned to inprogress

comment:20 Changed 5 years ago by Federico M Pouzols

  • Tester changed from Raquel Alvarez Banos to Federico M Pouzols

comment:21 Changed 5 years ago by Federico M Pouzols

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tested on debian, build of this morning's (20150429) master branch, and also Windows 3.3.20150428.2115-win64.

WorkspaceGroups work overall but it also seems that a few fixes would be needed. I can confirm the following outstanding issues:

  • #10519 - when you run an algorithm on a workspace group, even if it finishes happily it won't get to the proper finished (isExecuted) state.
  • #10728 - a workspace group is created, is empty, and you cannot delete it.
  • #10547 - algorithms applied on a group will not be complete if input validation fails for a member of the group.
  • #10521 - crash when renaming the group and members of the group to the same name.
  • #9867 - inconsistent behavior when re-creating workspace groups.

None of these are terribly urgent, but I can see how for example #10547 and #10519 can create issues for other algorithms, or prevent us from doing more thorough unit testing.

This was tested:

  • Context menu of group workspaces in the "Workspaces" window: plotSpectrum, color fill plots, save nexus.
  • LoadFITS (which loads and add new workspaces into groups).
  • A couple of Muon algorithms (from #10728).
  • Manual use of groups: create, add, rename and remove workspaces (with Python and the context menu).

comment:22 Changed 5 years ago by Nick Draper

  • Status changed from verify to closed
  • Resolution changed from fixed to worksforme

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7254

Note: See TracTickets for help on using tickets.