Ticket #6421 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Guard against the absence of the run_start property

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Release 2.4
Component: Mantid Keywords:
Cc: rgmiller@… Blocked By:
Blocking: Tester: Peter Peterson

Description

The LogManager::startTime() method throws an (undocumented) exception if the run_start (and the start_time) property is missing. With a 'normally' loaded file it's always (I think) there, but it's conceivable that it isn't with a live data stream.

This mainly shows up as a problem when trying to view the sample logs, if there are any time series property logs there. The relevant method is MantidUI::importNumSeriesLog.

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Russell Taylor

Re #6421. Add doxygen comments and format code.

Changeset: 63ff17e20ff5ab80b0fcf35d60c64a5883f42953

comment:3 Changed 8 years ago by Russell Taylor

Re #6421. Catch exception if run start time property is missing.

Use absolute times when displaying the log instead.

Changeset: ec3573b2b1e9da20c14fb88884e78e081c73712b

comment:4 Changed 8 years ago by Russell Taylor

Re #6421. Don't plot if displaying full dates instead of offsets.

It won't work anyway.

Changeset: f68bdfda7c3d2c78f122f8f6002b1d8d7843abd2

comment:5 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

This one is rather tricky to test, particularly on an installed Mantid. My best suggestion would be to test on a local build and change line 2425 of MantidUI.cpp (bool useAbsoluteDate = false;) to true. Make sure you don't check the change in!!!

comment:6 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:7 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to closed

It was a little confusing to verify, but this was done correctly.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7267

Note: See TracTickets for help on using tickets.