Ticket #6437 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Algorithm progress can get stuck at 100%

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

The progress bar stays at 100%, if you click details it is empty though, so it is just the progress bar.

This script causes it reliably on my pc (win 64)

for i in range(150):
    ws2 = Load('MUSR00015190.nxs')

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Priority changed from critical to major
  • Milestone changed from Release 2.4 to Release 2.5

Actually is takes two of these scripts running simultaneously to cause the problem, but one caused it stays for the last algorithm until restarted.

As the likelihood is lower, decreased in priority and moved back a release.

comment:2 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted
  • Milestone changed from Release 2.5 to Release 2.4

This keeps cropping up in testing and would be good to fix for this release.

comment:3 Changed 8 years ago by Martyn Gigg

Fix issue with progress reporting getting 'stuck' Refs #6437

When other threads started algorithms they messed up the assumption that the list of tracked algorithms would be empty when the last algorithm finished. The fix ensures all tracked algorithm pointers are removed when the corresponding algorithm finishes.

Changeset: 991aee2b9e284708687bfc661698f0d0009d393d

comment:4 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: The problem showed itself quite effectively by either running the above script in two separate tabs simultaneously or by running the script and trying to load a file through the Load button while it is running.

The effect now should be that the progress bar has disappeared when the last algorithm has finished.

comment:5 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:6 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Tested with version that didn't include fix and the progress bar remains visible. Version that includes changes, the progress bar is no longer there.

comment:7 Changed 8 years ago by Martyn Gigg

Fix issue with progress reporting getting 'stuck' Refs #6437

When other threads started algorithms they messed up the assumption that the list of tracked algorithms would be empty when the last algorithm finished. The fix ensures all tracked algorithm pointers are removed when the corresponding algorithm finishes.

Changeset: 991aee2b9e284708687bfc661698f0d0009d393d

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7283

Note: See TracTickets for help on using tickets.