Ticket #6444 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Plot spectrum dialog has no error markers

Reported by: Martyn Gigg Owned by: Gesner Passos
Priority: critical Milestone: Release 3.0
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Gesner Passos) (diff)

If you right-click on a multi-histogram workspace then the spectrum/index dialog pops up asking which you would like to plot. If you type a number that doesn't exist then the dialog stays as it should be there are no markers to indicate what is wrong.

Our usual red-star markers should be used to indicate the problem.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:2 Changed 7 years ago by Nick Draper

  • Owner set to Anyone
  • Priority changed from major to critical
  • Status changed from new to assigned

comment:3 Changed 7 years ago by Nick Draper

  • Owner changed from Anyone to Gesner Passos

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:5 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after R2.6

comment:7 Changed 7 years ago by Gesner Passos

  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.0

comment:8 Changed 7 years ago by Gesner Passos

  • Component changed from Framework to User Interface

comment:9 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

comment:10 Changed 7 years ago by Gesner Passos

Add the red star for plotSpectrum when wrong input is given

This is done by substituting the current QLineEdit for the input with a customized class that joins the QLineEdit and the * red mark, which is shown in case of error.

re #6444

Changeset: 24c07d1942fca325f8cebdc0d199179fa384d4f7

comment:11 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester:

the description of the ticket does explain how to test it. But, let's go step by step:

  • Load LOQ25654 (Any file to be honest)
  • Right-click workspace and select PlotSpectrum or Plot Spectrum with errors
  • Input an invalid range, and see the red mark. Put the mouse pointer in front of the mark, it will show up one message that the range was invalid.

comment:12 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:13 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

Selecting an invalid range for either workspace indices or spectra causes a red star to appear after the text box for either Plot Spectrum or Plot Spectrum with errors.

comment:14 Changed 7 years ago by Karl Palmen

Merge remote-tracking branch 'origin/feature/6444_plot_spectrum_error_marks'

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7290

Note: See TracTickets for help on using tickets.