Ticket #6481 (closed: duplicate)

Opened 8 years ago

Last modified 5 years ago

Use shared_ptrs in MatrixWorkspace get mapping functions

Reported by: Martyn Gigg Owned by: Russell Taylor
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by Russell Taylor) (diff)

Ticket #6157 highlighted another accidental misuse of these functions on MatrixWorkspace: 

index2spec_map * getWorkspaceIndexToSpectrumMap() const;
spec2index_map * getSpectrumToWorkspaceIndexMap() const;
index2detid_map * getWorkspaceIndexToDetectorIDMap() const;
detid2index_map * getDetectorIDToWorkspaceIndexMap( bool throwIfMultipleDets ) const;

If we are going to keep them they should at least return shared_ptrs.

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Cc taylorrj@… removed
  • Description modified (diff)

Agreed, though it would be nice if they could go away entirely. The first two should go away under #6191.

comment:2 Changed 8 years ago by Russell Taylor

  • Owner set to Russell Taylor
  • Status changed from new to verify
  • Resolution set to duplicate

This turns out to be a duplicate of #6198.

comment:3 Changed 8 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:4 Changed 8 years ago by Anders Markvardsen

  • Status changed from verifying to closed

The work for this ticket is in process in #6198

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7327

Note: See TracTickets for help on using tickets.