[ICAT] Algorithm error reporting

[Owen Arnold]

A lot of algorithms in the ICAT category are throwing the same basic exception message.

throw std::runtime_error("Error when getting the catalog information from the Facilities.xml file.");

Some of these were replaced as part of #6490 to give better information on login. It would be best if someone where to go through these error scenarios and check that

• They are reporting the right information, which should be useful to the end-user
• That there is reduced duplication of error messages. Looks like a lot of copy-paste at the moment.

The quick fix #6490 should also be reviewed, because the throwCatalogError() function is duplicated across two algorithms.

Nick. Reassign as you see appropriate. It might be that I'm the best person to look at this.

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Nick Draper]

Moved to backlog at the code freeze for R2.6

[Jay Rainey]

There has been no changes made in this ticket. However, I have made changes in #8322 that address this ticket so you can test with a develop build.

To test

1. Open Mantid, and click Help -> First time setup and change your facility to something other than ISIS.
2. Attempt to log into the catalog and you will receive an error message explaining why.

Ensure the changes in #8322 address the error reporting in Mantid ensuring that there is no longer a duplication of error messages across algorithms.

[Roman Tolchenov]

Algorithms CatalogListInstruments, CatalogListInvestigationTypes, CatalogMyDataSearch catch all runtime errors and throw another one with the same message "Please login..." regardless of the cause of the caught exception and discarding its message. I think the exceptions need to be differentiated here, for example have a specialized LoginError.

I seems that ICat4Catalog.h is missing in CMakeLists.txt.

[Jay Rainey]

I have removed the related try/catch in #8445 as they are no longer needed, and added the header file in #8446.

To test this ticket download & install a develop build and ensure changes in #8322 address this ticket, as described in comment:13.

[Nick Draper]

Too many things going on at the same time

[Owen Arnold]

Since this ticket is now dependent on 8445. Set that as the blocker for this.

[Alex Buts]

No such error exists in the code any more.

otherwise, seems works fine.

[Stuart Campbell]

This ticket has been transferred to github issue ​7358