Ticket #6523 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Clicking cancel on instrument dialog shouldn't bring up interface

Reported by: Michael Reuter Owned by: Mathieu Doucet
Priority: major Milestone: Release 2.6
Component: SANS Keywords:
Cc: Blocked By: #6924
Blocking: Tester: Russell Taylor

Description

When using the instrument dialog associated ORNL SANS and DGS Reduction, if the cancel button is clicked a blank SANS Reduction interface is presented. I think that nothing should be shown.

Change History

comment:1 Changed 7 years ago by Mathieu Doucet

  • Status changed from new to verify
  • Resolution set to worksforme

Haven't seen that behavior. If an instrument UI is already loaded, clicking cancel simply closes the instrument dialog.

comment:2 Changed 7 years ago by Russell Taylor

  • Status changed from verify to reopened
  • Resolution worksforme deleted

This is if the UI is not already loaded.

To reproduce: Start MantidPlot - Select e.g. ORNL SANS - Up comes the instrument choosing dialog - Hit cancel - Up comes an empty interface.

It seems like there may be a need to clear the 'instrument_name' QSettings entry to see this (N.B. it would really be better if this looked at the default instrument in the Mantid.properties instead).

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:4 Changed 7 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

This is now fixed by Ticket #6924

comment:5 Changed 7 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:7 Changed 7 years ago by Russell Taylor

  • Blocked By 6924 added

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Hitting cancel now does what you'd expect.

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:10 Changed 7 years ago by Nick Draper

  • Component changed from Framework to SANS

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7369

Note: See TracTickets for help on using tickets.