Ticket #6526 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Numbering in FilterEvents

Reported by: Andrei Savici Owned by: Wenduo Zhou
Priority: minor Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Wenduo Zhou) (diff)

In FilterEvents the workspaces are numbered from 0. If you choose to group these, an algorithm will act on the group, but the output workspaces are numbered from 1. Change FilterEvents to output good data from 1.

With the new option, first the unfiltered workspace will be not output. Then the other workspaces will start from index 1 and be consecutive. No workspace will be removed even if there is no event inside.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:5 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:7 Changed 7 years ago by Wenduo Zhou

  • Milestone changed from Backlog to Release 3.0

comment:8 Changed 7 years ago by Wenduo Zhou

The present implementation of FilterEvents sets the name of the output workspace as BaseName + SplitterIndex. The SplitterIndex is an internal value of the SplitterWorkspace containing the splitter. Therefore, to make the workspace to be numbered from 1, user should specify an offset on the splitter index.

comment:9 Changed 7 years ago by Wenduo Zhou

  • Milestone changed from Release 3.0 to Release 3.1

comment:10 Changed 7 years ago by Wenduo Zhou

  • Description modified (diff)

comment:11 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to inprogress

Made the change but not finished. Refs #6526.

Changeset: 1446b09eadbdeeb09f9dbb0ace41a2cbca946cf0

comment:12 Changed 7 years ago by Wenduo Zhou

Added one more output property. Refs #6526.

Changeset: d8eabeb5778fb94669e11de583d5c659ef1266ff

comment:13 Changed 7 years ago by Wenduo Zhou

Changed output property name. Refs #6526.

The original name contained 'Workspace'. simpleapi.py treats any output property containing 'Workspace' as workspace.

Changeset: d80b7734c366d0730f93332db80118e279f0baed

comment:14 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:15 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:16 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/6526_numbering_eventfilter'

Full changeset: ​6357e07932ffb9812c0bfa0eb14a0463c1d45ece

comment:17 Changed 7 years ago by Andrei Savici

There should be some notes in the wiki section about unfiltered events. Wenduo says that it will be incorporated into a different ticket

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7372

Note: See TracTickets for help on using tickets.