Ticket #6536 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Protect access to run properties with a mutex

Reported by: Ross Miller Owned by: Ross Miller
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The live listener has multiple threads which may modify the same event workspace. Access to the workspace is protected with a mutex, but one thread was adding and modifying run properties on that workspace without locking the mutex.

Change History

comment:1 Changed 8 years ago by Ross Miller

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Ross Miller

Use a mutex to protect access to run properties

The live listener has multiple threads that modify an event workspace. It already uses a mutex to protect access to the workspace, but one thread was modifying properties on that workspace without locking the mutex.

Refs #6536

Changeset: 5aca2df8cd52e65eb7686ab6f480b728d0fc8694

comment:3 Changed 8 years ago by Ross Miller

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

OK. We should keep an eye on performance with all this locking/unlocking, but I haven't had a problem so far (& haven't thought through if there's an alternative).

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7382

Note: See TracTickets for help on using tickets.