Ticket #6538 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Q1D correct error propagation

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Q1D2 method addWaveAdj, the error is propagated as:

error2 = pixel_dep_error2 + pixel_dep_error2 * wave_dep + wave_dep_error2 *pixel_dep

The error should be only:

error2 = pixel_dep_error2 * wave_dep + wave_dep_error2 * pixel_dep

Correct the error, and update the system tests.

Change History

comment:1 Changed 8 years ago by Gesner Passos

  • Status changed from new to assigned

comment:2 Changed 8 years ago by Gesner Passos

The list of system tests I found is using Q1D: 

SANSCentreSample.SANSCentreSample
EQSANSBeamCenter.EQSANSBeamCenter
EQSANSBeamCenter.EQSANSBeamCenterEvent
SANS2DFrontNoGrav.SANS2DFrontNoGrav
SANS2DBatch.SANS2DBatch
EQSANSIQOutput.EQSANSBeamMonitor
EQSANSIQOutput.EQSANSDQOutput
EQSANSIQOutput.EQSANSDQPositiveOutput
EQSANSIQOutput.EQSANSIQOutput
LOQLoadMask.SANSSetCentreEnsureResultFront
LOQLoadMask.SANSSetCentreEnsureResultRear
LOQLoadMask.SANSSetCentreFindCenterInfluence
LOQLoadMask.SANSSetCentreReductionInfluence
SANS2DWaveloops.SANS2DWaveloops
SANSLOQBatch.SANSLOQBatch
SANS2DMultiPeriodAddFiles.SANS2DMultiPeriodAddFiles
EQSANSLive.EQSANSLive

comment:3 Changed 8 years ago by Gesner Passos

Tester:

Review the code change. Make sure you agree with the propose of the new propagation error.

comment:4 Changed 8 years ago by Gesner Passos

Change Propagation error

re #6538

Changeset: 65b5a0f82c7ef143083c0196a7707e6778c039a5

comment:5 Changed 8 years ago by Gesner Passos

Adjust the Unit Test for propagation error Q1D2

re #6538

Changeset: b9cbff3ec792a2286e52650cbfbb23db91f1345c

comment:6 Changed 8 years ago by Gesner Passos

  • Status changed from assigned to accepted

comment:7 Changed 8 years ago by Gesner Passos

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 8 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:9 Changed 8 years ago by Anders Markvardsen

  • Status changed from verifying to closed

I agree and Richard also pleased this was spotted

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7384

Note: See TracTickets for help on using tickets.