Ticket #6560 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

[IDA] Swap temperature reading between msdFit and Elwin

Reported by: Dereck Kachere Owned by: Dereck Kachere
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Dereck Kachere) (diff)

Remove temperature reading from msdFit and put it into ElWin.

(Changed the description of ticket; it was not specific enough.)

Attachments

irs26173_graphite002_red.nxs​ (1.2 MB) - added by Dereck Kachere 7 years ago.

Change History

comment:1 Changed 8 years ago by Dereck Kachere

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Dereck Kachere

refs #6560 Updated files

Changeset: b0d8b460e0427c5e04bdc878158f08ddd5f61305

comment:3 Changed 8 years ago by Dereck Kachere

Revert "refs #6560 Updated files"

This reverts commit b0d8b460e0427c5e04bdc878158f08ddd5f61305.

Changeset: 3e580f13a63d92280dbc5b4e8c21c26df4a9715b

System test failure. Previous build failed. Will wait till build is normal.

Last edited 8 years ago by Dereck Kachere (previous) (diff)

comment:4 Changed 8 years ago by Dereck Kachere

refs #6560 Updated files

This reverts commit 3e580f13a63d92280dbc5b4e8c21c26df4a9715b.

It is a revert of a revert, so identical to the first push.

Changeset: 5d44ab6f1ecf277fb7bba729ec3dead745f2ba7c

comment:5 Changed 8 years ago by Dereck Kachere

  • Status changed from accepted to verify
  • Resolution set to fixed

To test:

  • The two GUIs should function as normal.

Changes made are to accommodate for the GUI changes currently in the pipeline. This ticket will be referenced when the changes to the GUIs are pushed.

comment:6 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:7 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to verify
  • Tester Roman Tolchenov deleted

comment:8 Changed 8 years ago by Gesner Passos

  • Status changed from verify to reopened
  • Resolution fixed deleted

He will still add the changes to the GUI

comment:9 Changed 8 years ago by Dereck Kachere

refs #6560 A few slight additions.

Quite trivial. E.g. sorts out indentation in in IndirectCommon and uses old API temporarily in IDA.

Changeset: ddfff4eff82bc213756971821faa9547427bfbb4

comment:10 Changed 8 years ago by Dereck Kachere

refs #6560 A few slight additions.

Quite trivial. E.g. sorts out indentation in in IndirectCommon and uses old API temporarily in IDA.

Changeset: ddfff4eff82bc213756971821faa9547427bfbb4

comment:11 Changed 8 years ago by Dereck Kachere

  • Summary changed from Updates to IDA and C2E Scripts and Algs to [C2E/IDA] Updates to IDA and C2E Scripts and Algs

comment:12 Changed 8 years ago by Dereck Kachere

  • Status changed from reopened to accepted

comment:13 Changed 8 years ago by Dereck Kachere

refs #6560 Elwin now acquires the temperature instead of Fury

Changeset: e1a5d30b26f384909531ecc7ef1bb4cb23b7903b

comment:14 Changed 8 years ago by Ruth Mikkelson

Refs #6560 Added Titling and unit test

Changeset: 48f8f9ff4ca2ef599660f8ec3be4768f291df69b

comment:15 Changed 8 years ago by Ruth Mikkelson

Refs #6560 Added Titling and unit test

Changeset: 48f8f9ff4ca2ef599660f8ec3be4768f291df69b

comment:16 Changed 8 years ago by Ruth Mikkelson

Refs #6560 Added Titling and unit test

Changeset: 48f8f9ff4ca2ef599660f8ec3be4768f291df69b

comment:17 Changed 7 years ago by Dereck Kachere

  • Description modified (diff)
  • Summary changed from [C2E/IDA] Updates to IDA and C2E Scripts and Algs to [IDA] Swap temperature reading between msdFit and Elwin

comment:18 Changed 7 years ago by Dereck Kachere

refs #6560 A few slight additions.

Quite trivial. E.g. sorts out indentation in in IndirectCommon and uses old API temporarily in IDA.

Changeset: ddfff4eff82bc213756971821faa9547427bfbb4

comment:19 Changed 7 years ago by Dereck Kachere

refs #6560 Elwin now acquires the temperature instead of Fury

Changeset: e1a5d30b26f384909531ecc7ef1bb4cb23b7903b

comment:20 Changed 7 years ago by Dereck Kachere

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

  • Open up Elwin in Indirect Data Analysis tab.
  • Input a file and ‘Plot Input’
  • Select the ranges to operate on and ‘Run’

In the Results Log, if no temperature file is found, you will be informed, otherwise you will see a statement notifying you of the temperature obtained from a file. Compared with the previous release version, you will see that MSDFit did the loading of temperature.

comment:21 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:22 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Unfortunately, I can't verify this.

  • I think the branch I should be testing is feature/6560_update_indirect_scripts, but I can't be sure, and It isn't explicitly stated.
  • Could you be mores specific about the 'file' that I should import, what format? where can I get it from?

Happy to re-test this ticket at the next possible opportunity if you can answer those questions for me.

Changed 7 years ago by Dereck Kachere

comment:23 Changed 7 years ago by Dereck Kachere

  • Status changed from reopened to accepted

comment:24 Changed 7 years ago by Dereck Kachere

  • Status changed from accepted to verify
  • Resolution set to fixed

The branch to be tested is indeed feature/6560_update_indirect_scripts.

Revised instructions:

  • Open up Elwin in Indirect Data Analysis tab.
  • Input the attached file and ‘Plot Input’.
  • Click ‘Run’(use the default ranges selected).

In the Results Log, if no temperature file is found, you will be informed, otherwise you will see a statement notifying you of the temperature obtained from a file.

Compared with the previous release version, you will see that MSDFit did the loading of temperature.

MSDFit takes the output of Elwin - a file ending in '_eq2.nxs' - as its input, so be sure to check the 'Save Result' option when you run Elwin, following the instructions set out at the top.

comment:25 Changed 7 years ago by Ruth Mikkelson

Refs #6560 Added Titling and unit test

Changeset: 48f8f9ff4ca2ef599660f8ec3be4768f291df69b

comment:26 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Owen Arnold to Martyn Gigg

comment:27 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified that the temperature is no read by Elwin and not msdfit. The output from both is still as expected.

comment:28 Changed 7 years ago by Dereck Kachere

refs #6560 A few slight additions.

Quite trivial. E.g. sorts out indentation in in IndirectCommon and uses old API temporarily in IDA.

Changeset: ddfff4eff82bc213756971821faa9547427bfbb4

comment:29 Changed 7 years ago by Dereck Kachere

refs #6560 Elwin now acquires the temperature instead of Fury

Changeset: e1a5d30b26f384909531ecc7ef1bb4cb23b7903b

comment:30 Changed 7 years ago by Ruth Mikkelson

Refs #6560 Added Titling and unit test

Changeset: 48f8f9ff4ca2ef599660f8ec3be4768f291df69b

comment:31 Changed 7 years ago by Dereck Kachere

refs #6560 A few slight additions.

Quite trivial. E.g. sorts out indentation in in IndirectCommon and uses old API temporarily in IDA.

Changeset: ddfff4eff82bc213756971821faa9547427bfbb4

comment:32 Changed 7 years ago by Dereck Kachere

refs #6560 Elwin now acquires the temperature instead of Fury

Changeset: e1a5d30b26f384909531ecc7ef1bb4cb23b7903b

comment:33 Changed 7 years ago by Dereck Kachere

refs #6560 A few slight additions.

Quite trivial. E.g. sorts out indentation in in IndirectCommon and uses old API temporarily in IDA.

Changeset: ddfff4eff82bc213756971821faa9547427bfbb4

comment:34 Changed 7 years ago by Dereck Kachere

refs #6560 Elwin now acquires the temperature instead of Fury

Changeset: e1a5d30b26f384909531ecc7ef1bb4cb23b7903b

comment:35 Changed 7 years ago by Dereck Kachere

refs #6560 A few slight additions.

Quite trivial. E.g. sorts out indentation in in IndirectCommon and uses old API temporarily in IDA.

Changeset: ddfff4eff82bc213756971821faa9547427bfbb4

comment:36 Changed 7 years ago by Dereck Kachere

refs #6560 Elwin now acquires the temperature instead of Fury

Changeset: e1a5d30b26f384909531ecc7ef1bb4cb23b7903b

comment:37 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7406

Note: See TracTickets for help on using tickets.