Ticket #6578 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Update scripts to api v2: ISIS SANS

Reported by: Nick Draper Owned by: Gesner Passos
Priority: blocker Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description (last modified by Anders Markvardsen) (diff)

Can you have a start on this one

Change History

comment:1 Changed 8 years ago by Nick Draper

  • Owner changed from Martyn Gigg to Anders Markvardsen
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Gesner Passos
  • Description modified (diff)

comment:3 Changed 8 years ago by Gesner Passos

Update the ISIS SANS related system tests to python v2

re #6578

Changeset: a0cde73080e7355164ec9642576057454422db98

comment:4 Changed 8 years ago by Gesner Passos

Move the SANSUtility to Python V2

re #6578

Changeset: eaa60ff6634869f53eb0dad58e75fc623d403b68

comment:5 Changed 8 years ago by Gesner Passos

Move the SANSadd2 to Python V2

re #6578

Changeset: a5167a54228710f429a11736eb1262af8d175e14

comment:6 Changed 8 years ago by Gesner Passos

Move the SANSBatchMode to Python V2

re #6578

Changeset: b1dfe746c762c9e2347c18f21f03a6cf1b34d7e6

comment:7 Changed 8 years ago by Gesner Passos

Move the isis_reduction_steps to Python V2

re #6578

Changeset: d9fddedfd2fb0e8f829179af97e6a27f05c6c5db

comment:8 Changed 8 years ago by Gesner Passos

Move the isis_reducer to Python V2

re #6578

Changeset: 3c71a46876cbc2767a8c15500c3ac2c3d3266c35

comment:9 Changed 8 years ago by Gesner Passos

Move the isis_instrument to Python V2

re #6578

Changeset: 044b53fd370827036fdded04380f3f287c7afbf8

comment:10 Changed 8 years ago by Gesner Passos

Move the centre_finder to Python V2

re #6578

Changeset: 1f0d95e843a6edbccf02f10531f6b5b79c42f31a

comment:11 Changed 8 years ago by Gesner Passos

Move the ISISCommandInterface to Python V2

re #6578

Changeset: 0707ad228b2e4bbfba3c28f005405fd03650e0d8

comment:12 Changed 8 years ago by Gesner Passos

Move isGroup to isinstance( WorkspaceGroup)

re #6578

Changeset: 0b1b541e0b9eb502c5cddd3833e7e8a7920874de

comment:13 Changed 8 years ago by Gesner Passos

Some catchas to be able to use from Mantid ISIS interface

re #6578

Changeset: 1020e7a3e097366aaa39b8dc3078dde4a8bb5534

comment:14 Changed 8 years ago by Gesner Passos

Remove the dependency on specific platform

allows to easily test that ISISCommandInterface is working

re #6578

Changeset: 8478b6c5caccdcb688962d9cfb79b53c233fabe7

comment:15 Changed 8 years ago by Gesner Passos

More changes that were triggered by the system tests

re #6578

Changeset: 5d9c5244f51da49cf82959b10a01592656497f65

comment:16 Changed 8 years ago by Gesner Passos

Solve bug on reducing MERGED data

NOT COVERED BY SYSTEM TESTS!

re #6578

Changeset: 8815b01af4b882d54a1de1d31b71313f2cdd5792

comment:17 Changed 8 years ago by Gesner Passos

Tester:

First of all, inspection of the code inside the scripts/SANS folder ensuring that the old version is not present. I found usefull to check the occurrences of mantid, mtd (to find mtd.sendLog, mtd.delete, mtd.settings).

Then, ensure that the SystemTests for LOQ/SANS2D at ISIS are ok: 

LOQCentreNoGrav
LOQTransFitWorkspace2D
SANS2DBatch
SANS2DFrontNoGrav
SANS2DMultiPeriodAddFiles
SANS2DWaveloops
SANSCentreSample
SANSLOQBatch
SANSLOQCan2D

Then, it good as well to see that the ISIS interface at MantidPlot is working properly.

  • Start ISIS SANS interface
  • Load MaskFile = MASKSANS2D.091A
  • Load BatchFile = SANS2D_periodTests.csv
  • Run Reduce1D
  • Change to SingleMode
  • Make Sample = 2500
  • Tab Analysis Details = change to Merge detectors
  • Run Reduce1D
  • Tab Geometry
  • Change Max iterations = 2 (otherwise you will wait to much)
  • Run
  • Tab Add runs
  • Add 2500 , 2500 (2 times)
  • Sum
  • Tab Diagnostics
  • 2500
  • Horizontal Integral
  • Vertical Integral

All these activities should be ok. And should be using the new api.

comment:18 Changed 8 years ago by Gesner Passos

  • Status changed from assigned to accepted

comment:19 Changed 8 years ago by Gesner Passos

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:20 Changed 8 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:21 Changed 8 years ago by Alex Buts

refs #6578 this is testers misunderstanding

Changeset: 91bd6546ff13445d21919496dbbbb22518162316

comment:22 Changed 8 years ago by Gesner Passos

Update the ISIS SANS related system tests to python v2

re #6578

Conflicts:

SystemTests/AnalysisTests/SANS2DBatch.py SystemTests/AnalysisTests/SANS2DMultiPeriodAddFiles.py SystemTests/AnalysisTests/SANSLOQBatch.py

Changeset: 0f7e08fdb52fb8dfd93ca1529b7dd6e053829227

comment:23 Changed 8 years ago by Alex Buts

refs #6578 results of merge problems

Changeset: 9803fac719ea7b2f1fb743f98fc6373fe4fdfdca

comment:24 Changed 8 years ago by Alex Buts

  • Status changed from verifying to closed

verified by building mantid without old api and repeating all system tests and the GUI workflow on Mantid without old API

All passed. The confusion was as the 6578 branch is present in Mantid but not present in SystemTests while this is a separate repository. Have to cherrypick the commit made to development when realized this. This caused additional commits due to non-clean merge.

comment:25 Changed 8 years ago by Alex Buts

refs #6578 this is testers misunderstanding

Changeset: 91bd6546ff13445d21919496dbbbb22518162316

comment:26 Changed 8 years ago by Gesner Passos

Update the ISIS SANS related system tests to python v2

re #6578

Conflicts:

SystemTests/AnalysisTests/SANS2DBatch.py SystemTests/AnalysisTests/SANS2DMultiPeriodAddFiles.py SystemTests/AnalysisTests/SANSLOQBatch.py

Changeset: 0f7e08fdb52fb8dfd93ca1529b7dd6e053829227

comment:27 Changed 8 years ago by Alex Buts

refs #6578 results of merge problems

Changeset: 9803fac719ea7b2f1fb743f98fc6373fe4fdfdca

comment:28 Changed 8 years ago by Gesner Passos

Move the SANSUtility to Python V2

re #6578

Changeset: eaa60ff6634869f53eb0dad58e75fc623d403b68

comment:29 Changed 8 years ago by Gesner Passos

Move the SANSadd2 to Python V2

re #6578

Changeset: a5167a54228710f429a11736eb1262af8d175e14

comment:30 Changed 8 years ago by Gesner Passos

Move the SANSBatchMode to Python V2

re #6578

Changeset: b1dfe746c762c9e2347c18f21f03a6cf1b34d7e6

comment:31 Changed 8 years ago by Gesner Passos

Move the isis_reduction_steps to Python V2

re #6578

Changeset: d9fddedfd2fb0e8f829179af97e6a27f05c6c5db

comment:32 Changed 8 years ago by Gesner Passos

Move the isis_reducer to Python V2

re #6578

Changeset: 3c71a46876cbc2767a8c15500c3ac2c3d3266c35

comment:33 Changed 8 years ago by Gesner Passos

Move the isis_instrument to Python V2

re #6578

Changeset: 044b53fd370827036fdded04380f3f287c7afbf8

comment:34 Changed 8 years ago by Gesner Passos

Move the centre_finder to Python V2

re #6578

Changeset: 1f0d95e843a6edbccf02f10531f6b5b79c42f31a

comment:35 Changed 8 years ago by Gesner Passos

Move the ISISCommandInterface to Python V2

re #6578

Changeset: 0707ad228b2e4bbfba3c28f005405fd03650e0d8

comment:36 Changed 8 years ago by Gesner Passos

Move isGroup to isinstance( WorkspaceGroup)

re #6578

Changeset: 0b1b541e0b9eb502c5cddd3833e7e8a7920874de

comment:37 Changed 8 years ago by Gesner Passos

Some catchas to be able to use from Mantid ISIS interface

re #6578

Changeset: 1020e7a3e097366aaa39b8dc3078dde4a8bb5534

comment:38 Changed 8 years ago by Gesner Passos

Remove the dependency on specific platform

allows to easily test that ISISCommandInterface is working

re #6578

Changeset: 8478b6c5caccdcb688962d9cfb79b53c233fabe7

comment:39 Changed 8 years ago by Gesner Passos

More changes that were triggered by the system tests

re #6578

Changeset: 5d9c5244f51da49cf82959b10a01592656497f65

comment:40 Changed 8 years ago by Gesner Passos

Solve bug on reducing MERGED data

NOT COVERED BY SYSTEM TESTS!

re #6578

Changeset: 8815b01af4b882d54a1de1d31b71313f2cdd5792

comment:41 Changed 8 years ago by Gesner Passos

Move the SANSUtility to Python V2

re #6578

Changeset: eaa60ff6634869f53eb0dad58e75fc623d403b68

comment:42 Changed 8 years ago by Gesner Passos

Move the SANSadd2 to Python V2

re #6578

Changeset: a5167a54228710f429a11736eb1262af8d175e14

comment:43 Changed 8 years ago by Gesner Passos

Move the SANSBatchMode to Python V2

re #6578

Changeset: b1dfe746c762c9e2347c18f21f03a6cf1b34d7e6

comment:44 Changed 8 years ago by Gesner Passos

Move the isis_reduction_steps to Python V2

re #6578

Changeset: d9fddedfd2fb0e8f829179af97e6a27f05c6c5db

comment:45 Changed 8 years ago by Gesner Passos

Move the isis_reducer to Python V2

re #6578

Changeset: 3c71a46876cbc2767a8c15500c3ac2c3d3266c35

comment:46 Changed 8 years ago by Gesner Passos

Move the isis_instrument to Python V2

re #6578

Changeset: 044b53fd370827036fdded04380f3f287c7afbf8

comment:47 Changed 8 years ago by Gesner Passos

Move the centre_finder to Python V2

re #6578

Changeset: 1f0d95e843a6edbccf02f10531f6b5b79c42f31a

comment:48 Changed 8 years ago by Gesner Passos

Move the ISISCommandInterface to Python V2

re #6578

Changeset: 0707ad228b2e4bbfba3c28f005405fd03650e0d8

comment:49 Changed 8 years ago by Gesner Passos

Move isGroup to isinstance( WorkspaceGroup)

re #6578

Changeset: 0b1b541e0b9eb502c5cddd3833e7e8a7920874de

comment:50 Changed 8 years ago by Gesner Passos

Some catchas to be able to use from Mantid ISIS interface

re #6578

Changeset: 1020e7a3e097366aaa39b8dc3078dde4a8bb5534

comment:51 Changed 8 years ago by Gesner Passos

Remove the dependency on specific platform

allows to easily test that ISISCommandInterface is working

re #6578

Changeset: 8478b6c5caccdcb688962d9cfb79b53c233fabe7

comment:52 Changed 8 years ago by Gesner Passos

More changes that were triggered by the system tests

re #6578

Changeset: 5d9c5244f51da49cf82959b10a01592656497f65

comment:53 Changed 8 years ago by Gesner Passos

Solve bug on reducing MERGED data

NOT COVERED BY SYSTEM TESTS!

re #6578

Changeset: 8815b01af4b882d54a1de1d31b71313f2cdd5792

comment:54 Changed 8 years ago by Gesner Passos

Move the SANSUtility to Python V2

re #6578

Changeset: eaa60ff6634869f53eb0dad58e75fc623d403b68

comment:55 Changed 8 years ago by Gesner Passos

Move the SANSadd2 to Python V2

re #6578

Changeset: a5167a54228710f429a11736eb1262af8d175e14

comment:56 Changed 8 years ago by Gesner Passos

Move the SANSBatchMode to Python V2

re #6578

Changeset: b1dfe746c762c9e2347c18f21f03a6cf1b34d7e6

comment:57 Changed 8 years ago by Gesner Passos

Move the isis_reduction_steps to Python V2

re #6578

Changeset: d9fddedfd2fb0e8f829179af97e6a27f05c6c5db

comment:58 Changed 8 years ago by Gesner Passos

Move the isis_reducer to Python V2

re #6578

Changeset: 3c71a46876cbc2767a8c15500c3ac2c3d3266c35

comment:59 Changed 8 years ago by Gesner Passos

Move the isis_instrument to Python V2

re #6578

Changeset: 044b53fd370827036fdded04380f3f287c7afbf8

comment:60 Changed 8 years ago by Gesner Passos

Move the centre_finder to Python V2

re #6578

Changeset: 1f0d95e843a6edbccf02f10531f6b5b79c42f31a

comment:61 Changed 8 years ago by Gesner Passos

Move the ISISCommandInterface to Python V2

re #6578

Changeset: 0707ad228b2e4bbfba3c28f005405fd03650e0d8

comment:62 Changed 8 years ago by Gesner Passos

Move isGroup to isinstance( WorkspaceGroup)

re #6578

Changeset: 0b1b541e0b9eb502c5cddd3833e7e8a7920874de

comment:63 Changed 8 years ago by Gesner Passos

Some catchas to be able to use from Mantid ISIS interface

re #6578

Changeset: 1020e7a3e097366aaa39b8dc3078dde4a8bb5534

comment:64 Changed 8 years ago by Gesner Passos

Remove the dependency on specific platform

allows to easily test that ISISCommandInterface is working

re #6578

Changeset: 8478b6c5caccdcb688962d9cfb79b53c233fabe7

comment:65 Changed 8 years ago by Gesner Passos

More changes that were triggered by the system tests

re #6578

Changeset: 5d9c5244f51da49cf82959b10a01592656497f65

comment:66 Changed 8 years ago by Gesner Passos

Solve bug on reducing MERGED data

NOT COVERED BY SYSTEM TESTS!

re #6578

Changeset: 8815b01af4b882d54a1de1d31b71313f2cdd5792

comment:67 Changed 8 years ago by Gesner Passos

Move the SANSUtility to Python V2

re #6578

Changeset: eaa60ff6634869f53eb0dad58e75fc623d403b68

comment:68 Changed 8 years ago by Gesner Passos

Move the SANSadd2 to Python V2

re #6578

Changeset: a5167a54228710f429a11736eb1262af8d175e14

comment:69 Changed 8 years ago by Gesner Passos

Move the SANSBatchMode to Python V2

re #6578

Changeset: b1dfe746c762c9e2347c18f21f03a6cf1b34d7e6

comment:70 Changed 8 years ago by Gesner Passos

Move the isis_reduction_steps to Python V2

re #6578

Changeset: d9fddedfd2fb0e8f829179af97e6a27f05c6c5db

comment:71 Changed 8 years ago by Gesner Passos

Move the isis_reducer to Python V2

re #6578

Changeset: 3c71a46876cbc2767a8c15500c3ac2c3d3266c35

comment:72 Changed 8 years ago by Gesner Passos

Move the isis_instrument to Python V2

re #6578

Changeset: 044b53fd370827036fdded04380f3f287c7afbf8

comment:73 Changed 8 years ago by Gesner Passos

Move the centre_finder to Python V2

re #6578

Changeset: 1f0d95e843a6edbccf02f10531f6b5b79c42f31a

comment:74 Changed 8 years ago by Gesner Passos

Move the ISISCommandInterface to Python V2

re #6578

Changeset: 0707ad228b2e4bbfba3c28f005405fd03650e0d8

comment:75 Changed 8 years ago by Gesner Passos

Move isGroup to isinstance( WorkspaceGroup)

re #6578

Changeset: 0b1b541e0b9eb502c5cddd3833e7e8a7920874de

comment:76 Changed 8 years ago by Gesner Passos

Some catchas to be able to use from Mantid ISIS interface

re #6578

Changeset: 1020e7a3e097366aaa39b8dc3078dde4a8bb5534

comment:77 Changed 8 years ago by Gesner Passos

Remove the dependency on specific platform

allows to easily test that ISISCommandInterface is working

re #6578

Changeset: 8478b6c5caccdcb688962d9cfb79b53c233fabe7

comment:78 Changed 8 years ago by Gesner Passos

More changes that were triggered by the system tests

re #6578

Changeset: 5d9c5244f51da49cf82959b10a01592656497f65

comment:79 Changed 8 years ago by Gesner Passos

Solve bug on reducing MERGED data

NOT COVERED BY SYSTEM TESTS!

re #6578

Changeset: 8815b01af4b882d54a1de1d31b71313f2cdd5792

comment:80 Changed 8 years ago by Gesner Passos

Move the SANSUtility to Python V2

re #6578

Changeset: eaa60ff6634869f53eb0dad58e75fc623d403b68

comment:81 Changed 8 years ago by Gesner Passos

Move the SANSadd2 to Python V2

re #6578

Changeset: a5167a54228710f429a11736eb1262af8d175e14

comment:82 Changed 8 years ago by Gesner Passos

Move the SANSBatchMode to Python V2

re #6578

Changeset: b1dfe746c762c9e2347c18f21f03a6cf1b34d7e6

comment:83 Changed 8 years ago by Gesner Passos

Move the isis_reduction_steps to Python V2

re #6578

Changeset: d9fddedfd2fb0e8f829179af97e6a27f05c6c5db

comment:84 Changed 8 years ago by Gesner Passos

Move the isis_reducer to Python V2

re #6578

Changeset: 3c71a46876cbc2767a8c15500c3ac2c3d3266c35

comment:85 Changed 8 years ago by Gesner Passos

Move the isis_instrument to Python V2

re #6578

Changeset: 044b53fd370827036fdded04380f3f287c7afbf8

comment:86 Changed 8 years ago by Gesner Passos

Move the centre_finder to Python V2

re #6578

Changeset: 1f0d95e843a6edbccf02f10531f6b5b79c42f31a

comment:87 Changed 8 years ago by Gesner Passos

Move the ISISCommandInterface to Python V2

re #6578

Changeset: 0707ad228b2e4bbfba3c28f005405fd03650e0d8

comment:88 Changed 8 years ago by Gesner Passos

Move isGroup to isinstance( WorkspaceGroup)

re #6578

Changeset: 0b1b541e0b9eb502c5cddd3833e7e8a7920874de

comment:89 Changed 8 years ago by Gesner Passos

Some catchas to be able to use from Mantid ISIS interface

re #6578

Changeset: 1020e7a3e097366aaa39b8dc3078dde4a8bb5534

comment:90 Changed 8 years ago by Gesner Passos

Remove the dependency on specific platform

allows to easily test that ISISCommandInterface is working

re #6578

Changeset: 8478b6c5caccdcb688962d9cfb79b53c233fabe7

comment:91 Changed 8 years ago by Gesner Passos

More changes that were triggered by the system tests

re #6578

Changeset: 5d9c5244f51da49cf82959b10a01592656497f65

comment:92 Changed 8 years ago by Gesner Passos

Solve bug on reducing MERGED data

NOT COVERED BY SYSTEM TESTS!

re #6578

Changeset: 8815b01af4b882d54a1de1d31b71313f2cdd5792

comment:93 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7424

Note: See TracTickets for help on using tickets.