Ticket #6596 (closed: invalid)
Load does not correctly recognize some raw files on MERLIN and Linux machines
Reported by: | Alex Buts | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | critical | Milestone: | Release 2.6 |
Component: | Framework | Keywords: | |
Cc: | martyn.gigg@… | Blocked By: | |
Blocking: | Tester: | Gesner Passos |
Description
if one tries to load some merlin file (e.g.) MER14336 using generic Load algorithm, the file is processed by incorrect loader (LoadPDFgetNFile)
The problem is observed on RHEL6 and Ubuntu and with some raw files (not all of them)
LoadRaw works correctly but generic load dialogue does not looks right.
Change History
comment:3 Changed 7 years ago by Nick Draper
- Priority changed from major to critical
- Owner set to Anyone
- Status changed from new to assigned
comment:6 Changed 7 years ago by Martyn Gigg
- Keywords Student,First removed
- Owner changed from Anyone to Martyn Gigg
My changes to the way the loader selection works have fixed this so it's no longer valid.
comment:8 Changed 7 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to invalid
This has been fixed as part of #7263 and should be tested after that has been verified and merge to master.
comment:9 Changed 7 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:10 Changed 7 years ago by Samuel Jackson
- Status changed from verifying to verify
- Tester Samuel Jackson deleted
This needs to wait until ticket #7263 has finished testing.
comment:11 Changed 7 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:12 Changed 7 years ago by Gesner Passos
- Status changed from verifying to closed
The problem has 'disapeared' ;)
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7442
So a quick look at the code suggests to me that the problem is with LoadPDFgetNFile's quickFileCheck & fileCheck methods. It opens the file and starts trying to read it line-by-line looking for a line starting with #L". On linux there is no distinction between text & binary data from the point of view of fstream so I think it just gets unlucky when some files have a sequence that looks like "#L" in the file.
I would think the fix would be a proper check of whether the file is ascii or not. See LoadAscii::isAscii method.