Ticket #6598 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create and example test for the MDEWRebinningPresenter

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: minor Milestone: Release 2.5
Component: VATES Keywords:
Cc: reuterma@… Blocked By:
Blocking: Tester: Michael Reuter

Description

Michael needs this. Because I've tried to keep the dependencies low, I've ended up mocking a lot of things. This affects readability. It would be friendlier to provide at least one test method that was properly explained and easy to follow.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

  • Component changed from Mantid to VATES

comment:3 Changed 8 years ago by Owen Arnold

refs #6598 added test and descriptions.

Changeset: 24cc4e60f36d63ea9452955f6bc2199a2ee87981

comment:4 Changed 8 years ago by Owen Arnold

refs #6598 Take out boost optional as quick fix.

Changeset: 2507b7f4cda3f915e41ecb4d6023fcf6f67f2a3c

comment:5 Changed 8 years ago by Owen Arnold

refs #6598 added test and descriptions. (cherry picked from commit 24cc4e60f36d63ea9452955f6bc2199a2ee87981)

Changeset: c8145ba8f0b5345780acfbc1a279fa060894cf1c

comment:6 Changed 8 years ago by Owen Arnold

refs #6598 Take out boost optional as quick fix. (cherry picked from commit 2507b7f4cda3f915e41ecb4d6023fcf6f67f2a3c)

Changeset: bb7e1db669678bf6cd04a4547f71aee6b6600624

comment:7 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

This work was originally done on it's own branch 6589_vates_api_test_example. Under this ticket I provided a working unit test MDEWRebinningPresenterTest::testExecute(). This has then been used for the basis of other tests under ticket branch 6541_3d_axis_label.

As the ticket was to provide a working unit test, so if this test has not been omitted, it should be running on all platforms. That is all that should be tested.

comment:8 Changed 8 years ago by Owen Arnold

refs #6598 added test and descriptions. (cherry picked from commit 24cc4e60f36d63ea9452955f6bc2199a2ee87981)

Changeset: c8145ba8f0b5345780acfbc1a279fa060894cf1c

comment:9 Changed 8 years ago by Owen Arnold

refs #6598 Take out boost optional as quick fix. (cherry picked from commit 2507b7f4cda3f915e41ecb4d6023fcf6f67f2a3c)

Changeset: bb7e1db669678bf6cd04a4547f71aee6b6600624

comment:10 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:11 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

This example helped immensely and allowed me to finish writing the tests I needed to complete some of the ParaView work.

comment:12 Changed 7 years ago by Owen Arnold

refs #6598 added test and descriptions. (cherry picked from commit 24cc4e60f36d63ea9452955f6bc2199a2ee87981)

Changeset: c8145ba8f0b5345780acfbc1a279fa060894cf1c

comment:13 Changed 7 years ago by Owen Arnold

refs #6598 Take out boost optional as quick fix. (cherry picked from commit 2507b7f4cda3f915e41ecb4d6023fcf6f67f2a3c)

Changeset: bb7e1db669678bf6cd04a4547f71aee6b6600624

comment:14 Changed 7 years ago by Owen Arnold

refs #6598 added test and descriptions. (cherry picked from commit 24cc4e60f36d63ea9452955f6bc2199a2ee87981)

Changeset: c8145ba8f0b5345780acfbc1a279fa060894cf1c

comment:15 Changed 7 years ago by Owen Arnold

refs #6598 Take out boost optional as quick fix. (cherry picked from commit 2507b7f4cda3f915e41ecb4d6023fcf6f67f2a3c)

Changeset: bb7e1db669678bf6cd04a4547f71aee6b6600624

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7444

Note: See TracTickets for help on using tickets.