Ticket #6616 (closed: fixed)
Show error in fitting tab
Reported by: | Anders Markvardsen | Owned by: | Arturs Bekasovs |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Muon | Keywords: | |
Cc: | stephen.cottrell@… | Blocked By: | |
Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Roman Tolchenov) (diff)
Request from Steve Cottrell.
After a fit display the error in brackets
Type LinearBackground
A0 9.213 (0.040)
A1 7.123 (0.080)
Steve e.g. look at the errors when e.g. fit several exponential, where large errors can indicate strong correlation. He would prefer to have this in the fitting tab rather than (remembering to) they are in table parameter workspace, and he things in particular inexperience users of Mantid would benifit from this also.
There should be an option in preferences to turn in on or off. I am not sure what the best default value for this should be.
Regardless of this choice when this feature has been implemented the Fitting tab in the muon interface will have this feature set to on.
Change History
comment:2 Changed 8 years ago by Anders Markvardsen
- Priority changed from minor to major
Speaking to Steve Cottrell, Francis Pratt also requested this.
One problem is that while collecting data you may repeatedly load and fit a run until a particular statistical accuracy has been reached. It's much simpler to see the result if the error is alongside the parameter value.
comment:4 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:5 Changed 7 years ago by Roman Tolchenov
- Owner changed from Roman Tolchenov to Arturs Bekasovs
- Description modified (diff)
comment:7 Changed 7 years ago by Arturs Bekasovs
- Summary changed from Show error in fitting tab to [Muon] Show error in fitting tab
comment:8 Changed 7 years ago by Arturs Bekasovs
- Milestone changed from Release 3.1 to Backlog
Not entirely sure how to approach that one. Will not have time in this release.
comment:9 Changed 7 years ago by Arturs Bekasovs
- Milestone changed from Backlog to Release 3.2
- Component changed from MantidPlot to Muon
- Summary changed from [Muon] Show error in fitting tab to Show error in fitting tab
comment:10 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state
comment:11 Changed 7 years ago by Arturs Bekasovs
- Status changed from assigned to inprogress
Refs #6616. Specialized property manager for parameters
It is currently a regular QtDoublePropertyManager, so nothing the fit browser should still work correctly. It gives me a way of overriding the manager for parameter properties only, leaving other double properties alone.
Changeset: 62ba1c1f5927de9c80814c0d80b58f5a013d1ef8
comment:12 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Specialized version of property manager for parameters
Changeset: a3210c09aae6ff8ff3af986fb2137b26961fb7ef
comment:13 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Implement error setting and proper displaying
Still a few things to do, but the basic functionality works perfectly
Changeset: 3db8431ca97cbbf6701a57bae94b290d5dd1f844
comment:14 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Specialized on-change function for parameters
Changeset: 79724a9dc889cbc5aaea536d2d37824e9bbfbbc3
comment:15 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Clear parameter error when the value get edited
Changeset: 0f65ab6b3dc5f380039dcb932a415a60f3595473
comment:16 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Make error setting to update the parameter display
Remove some unnecessary constness as well.
Changeset: ab078bfe62e013ab5522358c8e3af9974210f086
comment:17 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Set error values only when actual fit was done
Changeset: 41b954d8c8fff40b8b2114c8f821ceb9394577b7
comment:18 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Remove constness from error map
Changeset: 2bbe16352268370ebd140c4e014b25ab9498450a
comment:19 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Make it possible to turn error display on and off
Changeset: da3297051611d6930f8c8dd4670e873ee9f94d98
comment:20 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Add the new option to the Muon fit browser
Changeset: 87c68195d380c7951c981bbc2f16e839d818c8b0
comment:21 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Clear errors when doing undoFit
Plus some code refactoring to avoid repeating myself
Changeset: 6eaa99ee08ab68715b8b673dcc16c2344e244385
comment:22 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Attempt to fix broken builds.
- Missing DLLExport for windows
- Calling templated constructor
Changeset: 44cd3eb494595ea2b3ae10dd9d108cc91a24b622
comment:23 Changed 7 years ago by Arturs Bekasovs
Tester:
New option and default value
A new option was added to the Fit Function browser, called "Show Parameter Errors". Verify that it was indeed added to both general Fit Browser and Muon one ( MuonAnalysis -> Data Analysis).
Before changing the value, verify that the default value is as expected. It should be set to false (for now, at least) in general fit browser and to true in Muon fit browser.
The value should be save-able. Change value, re-start Mantid and make sure it stays the same. Check that for both fit browsers.
Disabled behaviour
When option is disabled, fit browser should behave as usual. Try to fit a data set to a few fit functions, change a few options, use Undo fit etc. While doing that, make sure fit browser is functional and that parameter fields have their values displayed only.
Enabled behaviour
Enable the option. Now whenever you complete a fit, parameter errors should be shown next to parameter values. Errors should be updated when repeating fits.
Verify that error values are correct by inspecting the *_Parameters workspace created during the fit.
If should still be possible to edit the value. When the value is edited, the error should disappear. Doing another fit should show it again.
All the errors should disappear when Undo fit is done.
Disabling error showing should make all errors disappear. Re-enabling it shows errors again, but only those which where set.
comment:24 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Minor improvements
Changeset: 0fb68013861a3f6ce5ddf048b046bd2870885267
comment:25 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Better error formatting
Changeset: a012a0bf10eb3d12e9f0f3b26d711f3f82f2ff9c
comment:26 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Add missing include for fabs
Changeset: 20e48a950b43842de32e49593109868078b2d87c
comment:27 Changed 7 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to fixed
comment:28 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:29 Changed 7 years ago by Roman Tolchenov
A couple of suggestions:
- Clicking on the parameter value starts an editor. When the editor loses focus the error always disappear regardless of whether the value changes or not. I suggest keeping the error visible if the value doesn't change.
- The parameter tooltips should say that the number in brackets is the fitting error.
comment:30 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:31 Changed 7 years ago by Arturs Bekasovs
- Status changed from reopened to inprogress
Refs #6616. Clear error only when the parameter was really changed
Changeset: 78e2469bc3db832ed9b466640991e211b65f9d8a
comment:32 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Move param descr. handling to parameter manager
This will allow me to update it more easily and when it's needed
Changeset: 8da86b364605587cc3c7ee2da3c337c640c6164d
comment:33 Changed 7 years ago by Arturs Bekasovs
Refs #6616. Add error description to the tooltip, when one is set
Changeset: 7ee4e52798df73a2295f045e455b330a29f4e5ae
comment:34 Changed 7 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to fixed
comment:36 Changed 7 years ago by Roman Tolchenov
Working as expected
comment:37 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/6616_muon_error_in_fit_browser'
Full changeset: cddcde2885e56aed7bd60db3fedd8a78b5d35855
comment:38 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7462