Ticket #6621 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

MultiDomainFunction doesn't work in a real example.

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

Update a script that uses MultiBG function to use MultiDomainFunction.

Attachments

FuryFitMult.py​ (1.5 KB) - added by Roman Tolchenov 8 years ago.
MultiDomainFit.py​ (977 bytes) - added by Roman Tolchenov 8 years ago.
This is my working progress
MultiDomainFit.2.py​ (1.7 KB) - added by Roman Tolchenov 7 years ago.

Change History

Changed 8 years ago by Roman Tolchenov

Changed 8 years ago by Roman Tolchenov

This is my working progress

comment:1 Changed 8 years ago by Roman Tolchenov

  • Cc spencer.howells@… added

Changed 7 years ago by Roman Tolchenov

comment:2 Changed 7 years ago by Roman Tolchenov

The function actually works. The test script was failing because the data contained zeros which the particular model didn't like.

To test:

run MultiDomainFit.2.py in MantidPlot and check that fit is successful, and there are no NANs visible. The output parameters table must contain reasonable values and all Betas must be equal.

This ticket doesn't have a branch.

comment:3 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:4 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to reopened
  • Resolution fixed deleted

Python simpleapi Fit function needs correction to work properly with multi-domain functions.

comment:6 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:7 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: d691912707f71ee0cbe8087dcfb18df2419a1fcd

comment:8 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: a6cc1c96029b55f54d3c3f53eef5aee5c8d32e9b

comment:9 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: d691912707f71ee0cbe8087dcfb18df2419a1fcd

comment:10 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: a6cc1c96029b55f54d3c3f53eef5aee5c8d32e9b

comment:11 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 698cec199adc25b76b27d0727cca8551b4cceb79

comment:12 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 698cec199adc25b76b27d0727cca8551b4cceb79

comment:13 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

To tester:

there is a branch now: feature/6621_multi_domain_fit

comment:14 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:15 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I tried to run MultiDomainFit.2.py (​http://trac.mantidproject.org/mantid/attachment/ticket/6621/MultiDomainFit.2.py). But I found at line 18, there is a syntax error.

comment:16 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:17 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:18 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying

comment:19 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

MultiDomainFit.2.py yields the result as required. And all the unit tests pass. So I close this ticket.

comment:20 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: 37d5e9290b865ddedfd946c0cf301d611d450dd1

comment:21 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: 46223fada85e26c380e4748c4f7b7b2d129c8dd0

comment:22 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 07865704003051729c9e7876c0c252f0792b9970

comment:23 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: 37d5e9290b865ddedfd946c0cf301d611d450dd1

comment:24 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: 46223fada85e26c380e4748c4f7b7b2d129c8dd0

comment:25 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 07865704003051729c9e7876c0c252f0792b9970

comment:26 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: 37d5e9290b865ddedfd946c0cf301d611d450dd1

comment:27 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: 46223fada85e26c380e4748c4f7b7b2d129c8dd0

comment:28 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 07865704003051729c9e7876c0c252f0792b9970

comment:29 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: 37d5e9290b865ddedfd946c0cf301d611d450dd1

comment:30 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: 46223fada85e26c380e4748c4f7b7b2d129c8dd0

comment:31 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 07865704003051729c9e7876c0c252f0792b9970

comment:32 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: d691912707f71ee0cbe8087dcfb18df2419a1fcd

comment:33 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: a6cc1c96029b55f54d3c3f53eef5aee5c8d32e9b

comment:34 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 698cec199adc25b76b27d0727cca8551b4cceb79

comment:35 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: d691912707f71ee0cbe8087dcfb18df2419a1fcd

comment:36 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: a6cc1c96029b55f54d3c3f53eef5aee5c8d32e9b

comment:37 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 698cec199adc25b76b27d0727cca8551b4cceb79

comment:38 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: d691912707f71ee0cbe8087dcfb18df2419a1fcd

comment:39 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: a6cc1c96029b55f54d3c3f53eef5aee5c8d32e9b

comment:40 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 698cec199adc25b76b27d0727cca8551b4cceb79

comment:41 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: 37d5e9290b865ddedfd946c0cf301d611d450dd1

comment:42 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: 46223fada85e26c380e4748c4f7b7b2d129c8dd0

comment:43 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 07865704003051729c9e7876c0c252f0792b9970

comment:44 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: d691912707f71ee0cbe8087dcfb18df2419a1fcd

comment:45 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: a6cc1c96029b55f54d3c3f53eef5aee5c8d32e9b

comment:46 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 698cec199adc25b76b27d0727cca8551b4cceb79

comment:47 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: d691912707f71ee0cbe8087dcfb18df2419a1fcd

comment:48 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: a6cc1c96029b55f54d3c3f53eef5aee5c8d32e9b

comment:49 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 698cec199adc25b76b27d0727cca8551b4cceb79

comment:50 Changed 7 years ago by Roman Tolchenov

Fit() in simpleapi sets additional properties in correct order.

Re #6621.

Changeset: 37d5e9290b865ddedfd946c0cf301d611d450dd1

comment:51 Changed 7 years ago by Roman Tolchenov

Added a test for this case. Re #6621.

Changeset: 46223fada85e26c380e4748c4f7b7b2d129c8dd0

comment:52 Changed 7 years ago by Roman Tolchenov

Fixing the test for rhel6. Re #6621.

Changeset: 07865704003051729c9e7876c0c252f0792b9970

comment:53 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6861_putback_output' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:54 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6621_multi_domain_fit' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:55 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6621_multi_domain_fit' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:56 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6861_putback_output' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:57 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6621_multi_domain_fit' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:58 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6621_multi_domain_fit' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:59 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7467

Note: See TracTickets for help on using tickets.