Ticket #6629 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

New API needs to add script directories to path

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Currently only the old API is adding Python script directories to the Python path. The new one needs to do this too.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Martyn Gigg

Make new Python API setup python paths. Refs #6629

There is now more flexibility in that the key in the properties file is not recursive at all. In the past it said it wasn't but still added the top level directories. In addition you can now add a directory with a init.py file in it if you wish to and you won't be banned by the frameork.

Changeset: fe42bb5128418683bf9d8eda82517a7859c9180a

comment:3 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: The best way to test this is from the standalone python command.

  • Start up the python interpreter from command line in the bin directory;
  • Do import mantid
  • Do import sys
  • Type sys.path

The list should contain the necessary scripting directories

comment:4 Changed 8 years ago by Russell Taylor

Re #6629. Add code to fix variables in installed properties file.

This is just a temporary fix to get things working again on an installed Mantid. The MANTID_ROOT variable is redefined before the installed Mantid.properties file is generated from the template, and so the variables that depend on that need changing as well.

Changeset: 5a7a169de297c9ddad4d5c9ad204d70110e5fa6d

comment:5 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:6 Changed 8 years ago by Martyn Gigg

Fix install prefix on packaing for script dir keys. Refs #6629

This just takes the build version and replaces the old MANTID_ROOT with the correct version for the packaging

Changeset: faa2afdd9d83a2c03d24a4f7da78768b5db9e945

comment:7 Changed 8 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:8 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Additional note to tester: Please test this on both a build & package version

comment:9 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:10 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

Looks to be working for both the old and new api for both installed mantid, and mantid built from source.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7475

Note: See TracTickets for help on using tickets.