Ticket #6635 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Make MaskDetectorsIf.cpp put allowed values directly into properties & wiki

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 2.5
Component: Mantid Keywords: refactor
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

This algorithm has two properties whose allowed values are defined in the code. They could be fed directly into the description in the desclarePorterty call and from there appear in the wiki.

This would make it easy to modify the allowed values in future and keep documentation up to date.

Change History

comment:1 Changed 8 years ago by Karl Palmen

  • Owner set to Karl Palmen
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:3 Changed 8 years ago by Karl Palmen

Created new branch 6635-maskdetif_doc

comment:4 Changed 8 years ago by Karl Palmen

List of allowed values generated automatically re #6635

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 13d064168a03f902f033c080d9022afef6de2823

comment:5 Changed 8 years ago by Karl Palmen

List of allowed values generated automatically re #6635

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 13d064168a03f902f033c080d9022afef6de2823

comment:6 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test I suggest taking the code, modify some of the allowed values of the two properties (Mode and Operator) . Then run wikimaker with the dryrun and see that the modified allowed values appear. Then discard your change in the allowed values.

comment:7 Changed 8 years ago by Karl Palmen

Merge branch 'tube_calibration_1' into develop. Refs #6635

Conflicts:

Code/Mantid/Framework/Algorithms/test/ApplyCalibrationTest.h

Changeset: bc6cfe5625a70d5f10ca4be6987b0aa70a84a44f

comment:8 Changed 8 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:9 Changed 8 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:10 Changed 8 years ago by Karl Palmen

List of allowed values generated automatically re #6635

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 00050779ae0054873acb1cb64032dbf65b6204d4

comment:11 Changed 8 years ago by Karl Palmen

List of allowed values generated automatically re #6635

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 00050779ae0054873acb1cb64032dbf65b6204d4

comment:12 Changed 8 years ago by Karl Palmen

List of allowed values generated automatically re #6635

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 00050779ae0054873acb1cb64032dbf65b6204d4

comment:13 Changed 8 years ago by Karl Palmen

List of allowed values generated automatically re #6635

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 00050779ae0054873acb1cb64032dbf65b6204d4

comment:14 Changed 8 years ago by Karl Palmen

List of allowed values generated automatically re #6635

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 00050779ae0054873acb1cb64032dbf65b6204d4

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7481

Note: See TracTickets for help on using tickets.