Ticket #6644 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

SassenaFFT produces warning when running second time

Reported by: Martyn Gigg Owned by: Jose Borreguero
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

While testing #6510 about running SassenaFFT twice I observed a warning "Workspace already exists in a WorkspaceGroup" that is most probably spurious but could confuse a user. Check whether the warning is necessary and fix it if possible.

To reproduce use the testing steps in the ticket mentioned above.

Attachments

example.h5 (17.7 KB) - added by Jose Borreguero 8 years ago.
Sassena output file containing I(Q,t>0)
example.py (246 bytes) - added by Jose Borreguero 8 years ago.
python script to run in MantidPlot

Change History

comment:1 Changed 8 years ago by Jose Borreguero

  • Status changed from new to accepted
  • Owner set to Jose Borreguero

Changed 8 years ago by Jose Borreguero

Sassena output file containing I(Q,t>0)

Changed 8 years ago by Jose Borreguero

python script to run in MantidPlot

comment:2 Changed 8 years ago by Jose Borreguero

WorkspaceGroup::addWorkspace() sends a warning message when the workspace being added is already present int he workspace group

comment:3 Changed 8 years ago by Jose Borreguero

Refs #6644 check if workspace already present in the group

Changeset: bff403afb40135039a3a4cb6c959d5e0e07bf80b

comment:4 Changed 8 years ago by Jose Borreguero

Refs #6644 check if workspace already present in the group

Changeset: bff403afb40135039a3a4cb6c959d5e0e07bf80b

comment:5 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

Testing feature/6644_sassenafft_warning_mssg:

  1. Download example.h5 and example.py
  2. In a MantidPlot session, run example.py

Check that:

  1. No warning messages are output in the results log window
  2. Workspaces 'clone' and 'example_sqw' are different. The first is a Gaussian, the second is a Gaussian with a negative dip and negative energies

comment:6 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:7 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to closed

The changes are already inside the master because they have been applied at #6776. If you try to merge it, it will complain about merging, but there are only spaces. So, I have not applied to master. The example.py runs withou warning. But, I found interesting that if you try to execute this code:

LoadSassena(Filename='example.h5',OutputWorkspace='example')
LoadSassena(Filename='example.h5',OutputWorkspace='example')

You get an exception:

RuntimeError:  add : Unable to insert Data Object : 'example_qvectors'
  at line 2 in 'example.py'
  caused by line 491 in 'mantid/simpleapi.py'

Is this acceptable? (The second line is useless, but should it throw exception?) Could you consider if this should be reported as a new ticket?

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7490

Note: See TracTickets for help on using tickets.