Ticket #6646 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

WikiMaker: Change ugly type of WorkspaceProperty<TableWorkspace>

Reported by: Gesner Passos Owned by: Owen Arnold
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

Look at the type properties of QResultWorkspace and QErrorWorkspace from http://www.mantidproject.org/SCDCalibratePanels, currently is: 

N5boost10shared_ptrIN6Mantid11DataObjects14TableWorkspaceEEE

It's necessary to change to a better user description.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Gesner Passos

Other examples: LoadSassena:

WorkspaceGroup : N5boost10shared_ptrIN6Mantid3API14WorkspaceGroupEEE

comment:3 Changed 8 years ago by Owen Arnold

refs #6646. Unmangle property types.

Property knows about more of the dataobject workspace types so that it can unmangle the names correctly.

Changeset: 5800d4e0a9663f56fa2b5dcd2ed3a761041a1201

comment:4 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: The problem here is that Property doesn't include these newer dataobject types into its un-mangling dictionary. So I've added.

DataObject:

  • SpecialWorkspace2D
  • SplitterWorkspace
  • TableWorkspace

I've also added unit tests for each of these types to check that the un-mangling is happening properly. These changes are on branch ​https://github.com/mantidproject/mantid/tree/feature/6646_property_mangling.

One way to test this would be to do a dummy run of the wikimaker ( --dry-run ) on SCDCalibratePanels and check that the property table created has an unmangled names for the Input and Output properties. Also check that the new unit tests are running and passing.

comment:5 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:6 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to closed

comment:7 Changed 8 years ago by Owen Arnold

refs #6646. Unmangle property types.

Property knows about more of the dataobject workspace types so that it can unmangle the names correctly.

Changeset: 5800d4e0a9663f56fa2b5dcd2ed3a761041a1201

comment:8 Changed 8 years ago by Owen Arnold

refs #6646. Unmangle property types.

Property knows about more of the dataobject workspace types so that it can unmangle the names correctly.

Changeset: 5800d4e0a9663f56fa2b5dcd2ed3a761041a1201

comment:9 Changed 8 years ago by Owen Arnold

refs #6646. Unmangle property types.

Property knows about more of the dataobject workspace types so that it can unmangle the names correctly.

Changeset: 88375b30c76a1c6aa196e9b4ed18b225984cdf8c

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7492

Note: See TracTickets for help on using tickets.