Ticket #6650 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Replace event filtering in SNSPowderReduction by splitters workspace

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: petersonpf@… Blocked By:
Blocking: #6555, #6556 Tester: Peter Peterson

Description

Remove the current section to do event filtering neither by time nor log value from SNSPowderReduction. Meanwhile, make the algorithm accept a SplittersWorkspace as input property. Such that the workspace created from data will be split by splitters in input SplittersWorkspace.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Wenduo Zhou

Implement new filtering mechanism. Refs #6650.

Changeset: 4d3062ec319413cea9425350b8c202c30f54abcd

comment:3 Changed 8 years ago by Wenduo Zhou

Modified to meet ticket request. Refs #6650.

Replaced filtering properties by splitters workspace; Removed the calls to FilterByTime and FilterByLogValue; Use FilterEvents instead.

Changeset: 80dffd9cc72a3d473350d816620d6ceebaeddb8e

comment:4 Changed 8 years ago by Wenduo Zhou

Implement new filtering mechanism. Refs #6650.

Changeset: 4d3062ec319413cea9425350b8c202c30f54abcd

comment:5 Changed 8 years ago by Wenduo Zhou

Modified to meet ticket request. Refs #6650.

Replaced filtering properties by splitters workspace; Removed the calls to FilterByTime and FilterByLogValue; Use FilterEvents instead.

Changeset: 80dffd9cc72a3d473350d816620d6ceebaeddb8e

comment:6 Changed 8 years ago by Wenduo Zhou

Some modification. Refs #6650.

Changeset: 5214788d32f197dcd3d12f77d81b648568002bc1

comment:7 Changed 8 years ago by Wenduo Zhou

Revert to the original one. Refs #6650.

Changeset: 6d59a3671146cb487297b959f99b121b5820497c

comment:8 Changed 8 years ago by Wenduo Zhou

Some modification. Refs #6650.

Changeset: 5214788d32f197dcd3d12f77d81b648568002bc1

comment:9 Changed 8 years ago by Wenduo Zhou

Revert to the original one. Refs #6650.

Changeset: 6d59a3671146cb487297b959f99b121b5820497c

comment:10 Changed 8 years ago by Wenduo Zhou

Implemented the requested change. Refs #6650.

Changeset: be4112491d852e49ae8ca233ca2a6b5492224380

comment:11 Changed 8 years ago by Wenduo Zhou

Implemented the requested change. Refs #6650.

Changeset: be4112491d852e49ae8ca233ca2a6b5492224380

comment:12 Changed 8 years ago by Wenduo Zhou

Fix a bug to count number of splitted workspaces. Refs #6650.

Changeset: 3f316b3475318e76f85cdb318edc1df9a5c7a15f

comment:13 Changed 8 years ago by Wenduo Zhou

Fix a bug to count number of splitted workspaces. Refs #6650.

Changeset: 3f316b3475318e76f85cdb318edc1df9a5c7a15f

comment:14 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 8 years ago by Wenduo Zhou

  • Blocking 6555, 6556 added

comment:16 Changed 8 years ago by Wenduo Zhou

Update system test. Refs #6650.

Changeset: 6c33b857a8997cb170c823f554847263f9a38f38

comment:17 Changed 8 years ago by Wenduo Zhou

Test

Note: the ticket is associated with branch feature/6650_powder_redux

  1. The system test, SNSPowderRedux, should be passed with SNSPowderReduction.
  1. Test with splitters workspace as input a) Get all data required by test 1 in SNSPowderRedux. b) Call GenerateEventsFilter() to generate a splitter workspace according to time; c) Call SNSPowderReduction() as test 1 but using the splitters workspace created in previous step. d) The reduced data should be similar but not exactly same as the golden data. The total number of events are fewer than the unfiltered.
Last edited 8 years ago by Wenduo Zhou (previous) (diff)

comment:18 Changed 8 years ago by Wenduo Zhou

Modify system test. Refs #6650.

Changeset: a2b1180b27b104ca8d8e6e1191ba612ac981104f

comment:19 Changed 8 years ago by Wenduo Zhou

Do some mod for debug on MacOS. Refs #6650.

Changeset: c961a7c12977588d5d7307c201a99a84841652f1

comment:20 Changed 8 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 823cdad623326ac376cb12d137f328a588848748

comment:21 Changed 8 years ago by Wenduo Zhou

Try to figure out Mac failure. Refs #6650.

Changeset: 1a1a5f9a3dcc3430931bab7695445a094d6794e7

comment:22 Changed 8 years ago by Wenduo Zhou

Still try to figure out Mac failure. Refs #6650.

Changeset: f51043841312f1511d33fec5b83a85d6ff55171d

comment:23 Changed 8 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

This does not pass all of the mac system tests.

comment:24 Changed 8 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 890bc21422d88615d1fdebf28529118bba2dcbf5

comment:25 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:26 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

Failure of system test SNSPowderRedux is not caused by SNSPowderReduction(). Ticket #6832 has fixed the problem.

comment:27 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:28 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This reintroduces bugs related to newer NOMAD data. Unfortunately the ​branch difference is quite big and difficult to see what is really changed. This was seen trying to reduce NOM_11848 and needs to be fixed before this can be passed.

comment:29 Changed 7 years ago by Wenduo Zhou

Do some mod for debug on MacOS. Refs #6650.

Changeset: c961a7c12977588d5d7307c201a99a84841652f1

comment:30 Changed 7 years ago by Wenduo Zhou

Try to figure out Mac failure. Refs #6650.

Changeset: 1a1a5f9a3dcc3430931bab7695445a094d6794e7

comment:31 Changed 7 years ago by Wenduo Zhou

Still try to figure out Mac failure. Refs #6650.

Changeset: f51043841312f1511d33fec5b83a85d6ff55171d

comment:32 Changed 7 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 890bc21422d88615d1fdebf28529118bba2dcbf5

comment:33 Changed 7 years ago by Wenduo Zhou

Implemented the requested change. Refs #6650.

Changeset: be4112491d852e49ae8ca233ca2a6b5492224380

comment:34 Changed 7 years ago by Wenduo Zhou

Fix a bug to count number of splitted workspaces. Refs #6650.

Changeset: 3f316b3475318e76f85cdb318edc1df9a5c7a15f

comment:35 Changed 7 years ago by Wenduo Zhou

Do some mod for debug on MacOS. Refs #6650.

Changeset: c961a7c12977588d5d7307c201a99a84841652f1

comment:36 Changed 7 years ago by Wenduo Zhou

Try to figure out Mac failure. Refs #6650.

Changeset: 1a1a5f9a3dcc3430931bab7695445a094d6794e7

comment:37 Changed 7 years ago by Wenduo Zhou

Still try to figure out Mac failure. Refs #6650.

Changeset: f51043841312f1511d33fec5b83a85d6ff55171d

comment:38 Changed 7 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 890bc21422d88615d1fdebf28529118bba2dcbf5

comment:39 Changed 7 years ago by Wenduo Zhou

Merge the changes on Feb 7 and 8. Refs #6650.

Changeset: f7d86610aa5e891537a8bd07063e6faec5057cec

comment:40 Changed 7 years ago by Wenduo Zhou

Merge the changes on Feb 7 and 8. Refs #6650.

Changeset: f7d86610aa5e891537a8bd07063e6faec5057cec

comment:41 Changed 7 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:42 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:43 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying

comment:44 Changed 7 years ago by Wenduo Zhou

Implemented the requested change. Refs #6650.

Changeset: be4112491d852e49ae8ca233ca2a6b5492224380

comment:45 Changed 7 years ago by Wenduo Zhou

Fix a bug to count number of splitted workspaces. Refs #6650.

Changeset: 3f316b3475318e76f85cdb318edc1df9a5c7a15f

comment:46 Changed 7 years ago by Wenduo Zhou

Do some mod for debug on MacOS. Refs #6650.

Changeset: c961a7c12977588d5d7307c201a99a84841652f1

comment:47 Changed 7 years ago by Wenduo Zhou

Try to figure out Mac failure. Refs #6650.

Changeset: 1a1a5f9a3dcc3430931bab7695445a094d6794e7

comment:48 Changed 7 years ago by Wenduo Zhou

Still try to figure out Mac failure. Refs #6650.

Changeset: f51043841312f1511d33fec5b83a85d6ff55171d

comment:49 Changed 7 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 890bc21422d88615d1fdebf28529118bba2dcbf5

comment:50 Changed 7 years ago by Wenduo Zhou

Merge the changes on Feb 7 and 8. Refs #6650.

Changeset: f7d86610aa5e891537a8bd07063e6faec5057cec

comment:51 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

It works now

comment:52 Changed 7 years ago by Wenduo Zhou

Implemented the requested change. Refs #6650.

Changeset: be4112491d852e49ae8ca233ca2a6b5492224380

comment:53 Changed 7 years ago by Wenduo Zhou

Fix a bug to count number of splitted workspaces. Refs #6650.

Changeset: 3f316b3475318e76f85cdb318edc1df9a5c7a15f

comment:54 Changed 7 years ago by Wenduo Zhou

Do some mod for debug on MacOS. Refs #6650.

Changeset: c961a7c12977588d5d7307c201a99a84841652f1

comment:55 Changed 7 years ago by Wenduo Zhou

Try to figure out Mac failure. Refs #6650.

Changeset: 1a1a5f9a3dcc3430931bab7695445a094d6794e7

comment:56 Changed 7 years ago by Wenduo Zhou

Still try to figure out Mac failure. Refs #6650.

Changeset: f51043841312f1511d33fec5b83a85d6ff55171d

comment:57 Changed 7 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 890bc21422d88615d1fdebf28529118bba2dcbf5

comment:58 Changed 7 years ago by Wenduo Zhou

Merge the changes on Feb 7 and 8. Refs #6650.

Changeset: f7d86610aa5e891537a8bd07063e6faec5057cec

comment:59 Changed 7 years ago by Wenduo Zhou

Implemented the requested change. Refs #6650.

Changeset: be4112491d852e49ae8ca233ca2a6b5492224380

comment:60 Changed 7 years ago by Wenduo Zhou

Fix a bug to count number of splitted workspaces. Refs #6650.

Changeset: 3f316b3475318e76f85cdb318edc1df9a5c7a15f

comment:61 Changed 7 years ago by Wenduo Zhou

Do some mod for debug on MacOS. Refs #6650.

Changeset: c961a7c12977588d5d7307c201a99a84841652f1

comment:62 Changed 7 years ago by Wenduo Zhou

Try to figure out Mac failure. Refs #6650.

Changeset: 1a1a5f9a3dcc3430931bab7695445a094d6794e7

comment:63 Changed 7 years ago by Wenduo Zhou

Still try to figure out Mac failure. Refs #6650.

Changeset: f51043841312f1511d33fec5b83a85d6ff55171d

comment:64 Changed 7 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 890bc21422d88615d1fdebf28529118bba2dcbf5

comment:65 Changed 7 years ago by Wenduo Zhou

Merge the changes on Feb 7 and 8. Refs #6650.

Changeset: f7d86610aa5e891537a8bd07063e6faec5057cec

comment:66 Changed 7 years ago by Wenduo Zhou

Implement new filtering mechanism. Refs #6650.

Changeset: 4d3062ec319413cea9425350b8c202c30f54abcd

comment:67 Changed 7 years ago by Wenduo Zhou

Some modification. Refs #6650.

Changeset: 5214788d32f197dcd3d12f77d81b648568002bc1

comment:68 Changed 7 years ago by Wenduo Zhou

Revert to the original one. Refs #6650.

Changeset: 6d59a3671146cb487297b959f99b121b5820497c

comment:69 Changed 7 years ago by Wenduo Zhou

Modified to meet ticket request. Refs #6650.

Replaced filtering properties by splitters workspace; Removed the calls to FilterByTime and FilterByLogValue; Use FilterEvents instead.

Changeset: 80dffd9cc72a3d473350d816620d6ceebaeddb8e

comment:70 Changed 7 years ago by Wenduo Zhou

Implemented the requested change. Refs #6650.

Changeset: be4112491d852e49ae8ca233ca2a6b5492224380

comment:71 Changed 7 years ago by Wenduo Zhou

Fix a bug to count number of splitted workspaces. Refs #6650.

Changeset: 3f316b3475318e76f85cdb318edc1df9a5c7a15f

comment:72 Changed 7 years ago by Wenduo Zhou

Do some mod for debug on MacOS. Refs #6650.

Changeset: c961a7c12977588d5d7307c201a99a84841652f1

comment:73 Changed 7 years ago by Wenduo Zhou

Try to figure out Mac failure. Refs #6650.

Changeset: 1a1a5f9a3dcc3430931bab7695445a094d6794e7

comment:74 Changed 7 years ago by Wenduo Zhou

Still try to figure out Mac failure. Refs #6650.

Changeset: f51043841312f1511d33fec5b83a85d6ff55171d

comment:75 Changed 7 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 890bc21422d88615d1fdebf28529118bba2dcbf5

comment:76 Changed 7 years ago by Wenduo Zhou

Merge the changes on Feb 7 and 8. Refs #6650.

Changeset: f7d86610aa5e891537a8bd07063e6faec5057cec

comment:77 Changed 7 years ago by Wenduo Zhou

Implemented the requested change. Refs #6650.

Changeset: be4112491d852e49ae8ca233ca2a6b5492224380

comment:78 Changed 7 years ago by Wenduo Zhou

Fix a bug to count number of splitted workspaces. Refs #6650.

Changeset: 3f316b3475318e76f85cdb318edc1df9a5c7a15f

comment:79 Changed 7 years ago by Wenduo Zhou

Do some mod for debug on MacOS. Refs #6650.

Changeset: c961a7c12977588d5d7307c201a99a84841652f1

comment:80 Changed 7 years ago by Wenduo Zhou

Try to figure out Mac failure. Refs #6650.

Changeset: 1a1a5f9a3dcc3430931bab7695445a094d6794e7

comment:81 Changed 7 years ago by Wenduo Zhou

Still try to figure out Mac failure. Refs #6650.

Changeset: f51043841312f1511d33fec5b83a85d6ff55171d

comment:82 Changed 7 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 890bc21422d88615d1fdebf28529118bba2dcbf5

comment:83 Changed 7 years ago by Wenduo Zhou

Merge the changes on Feb 7 and 8. Refs #6650.

Changeset: f7d86610aa5e891537a8bd07063e6faec5057cec

comment:84 Changed 7 years ago by Wenduo Zhou

Do some mod for debug on MacOS. Refs #6650.

Changeset: c961a7c12977588d5d7307c201a99a84841652f1

comment:85 Changed 7 years ago by Wenduo Zhou

Try to figure out Mac failure. Refs #6650.

Changeset: 1a1a5f9a3dcc3430931bab7695445a094d6794e7

comment:86 Changed 7 years ago by Wenduo Zhou

Still try to figure out Mac failure. Refs #6650.

Changeset: f51043841312f1511d33fec5b83a85d6ff55171d

comment:87 Changed 7 years ago by Wenduo Zhou

Fix an error. Refs #6650.

Changeset: 890bc21422d88615d1fdebf28529118bba2dcbf5

comment:88 Changed 7 years ago by Wenduo Zhou

Merge the changes on Feb 7 and 8. Refs #6650.

Changeset: f7d86610aa5e891537a8bd07063e6faec5057cec

comment:89 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7496

Note: See TracTickets for help on using tickets.