Ticket #6654 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Remove unused <offsets spherical> tags from IDF

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: taylorrj@… Blocked By:
Blocking: Tester: Karl Palmen

Description

Ticket to remove unused <offsets spherical> tags from IDF for reason explained in email exchange below:

Yes, I agree that it’s best to keep this tag out of all IDFs that don’t need it. It’s just for the very special case of IDFs I auto-generated from the Ariel equivalents a very long time ago.

Russell

From: anders.markvardsen@… anders.markvardsen@… Sent: Friday, March 01, 2013 4:07 AM To: Taylor, Russell J. Subject: <offsets spherical="vectors" />

Hi Russell,

Just a small pedantic thing, but which did confuse me quite a bit at first when writing http://www.mantidproject.org/IDF-ISIS-LET-annotated#An_annotated_version_of_the_ISIS_LET_IDF which annotates LET, was the line

<offsets spherical="vectors" />

since I read it as offsets was ON to start with. The behaviour of <offsets spherical=””> in the code (and on the wiki) is that offsets are OFF unless spherical=”delta”.

Would you happy if I add a ticket to go through all the IDFs and remove all occurrences of <offsets spherical="vectors" />?

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:2 Changed 7 years ago by Anders Markvardsen

remember <offsets spherical="vectors" />. re #6654

Changeset: 1c1c329b792762d1b4b7adb9486483bf439a7eb1

comment:3 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to accepted

comment:4 Changed 7 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test: Check that a search for <offsets spherical="vectors" /> in the instrument folder comes up with no hits

comment:5 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:6 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

I also tested with some combinations of a space character added or removed from the search string.

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7500

Note: See TracTickets for help on using tickets.