Ticket #6669 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Add LoadLogPopertyTable python algorithm

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description (last modified by Nick Draper) (diff)

Adding a user supplied and somewhat improved python algorithm

Unit tests and wiki pages should be included

Change History

comment:1 Changed 8 years ago by Nick Draper

re #6669 New LoadLogPropertyTable Algorithm

Changeset: 3b279ab5f1efa0dce67014e027190110f30887c0

comment:2 Changed 8 years ago by Nick Draper

To test, use the musr files in autotestdata, or any other range of files.

It should:

  1. Load any file type that Load can handle.
  2. Not crash with multiperiod data - although values will be from period 1
  3. Handle gaps in the file structure (although this can be slow over a network if you choose a range of 100s)
  4. Load only a single spectra of the data (if the file loader supports this).
  5. Print out the list of acceptable log names if one is entered incorrectly.
  6. Use a hidden workspace for the temporary loaded workspaces, and clean up after itself.

and create a table of log values against the run number. The log values can be entered as a comma separated list.

comment:3 Changed 8 years ago by Nick Draper

re #6669 Improved in file documentation

Changeset: 807d9a1da17f9071b0a44179273560dc37147101

comment:4 Changed 8 years ago by Nick Draper

  • Blocking 6668 removed

(In #6668) Some documentation added, needs improving

comment:4 Changed 8 years ago by Nick Draper

  • Status changed from new to accepted
  • Blocking 6668 added

branch is feature/6669_LoadLogPropertyTable

comment:5 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:7 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The algorithm runs from the script editor only.

comment:8 Changed 8 years ago by Russell Taylor

FYI, on the ORNL 'mantidunstable' build (built off develop), the following error message appears on startup: 

Error initializing LoadLogPropertyTable algorithm: global name 'StringArrayProperty' is not defined
  at line 17 in '/opt/mantidunstable/plugins/PythonAlgs/LoadLogPropertyTable.py'

comment:10 Changed 8 years ago by Nick Draper

re #6669 New LoadLogPropertyTable Algorithm

Changeset: 3b279ab5f1efa0dce67014e027190110f30887c0

comment:11 Changed 8 years ago by Nick Draper

re #6669 Improved in file documentation

Changeset: 807d9a1da17f9071b0a44179273560dc37147101

comment:12 Changed 8 years ago by Nick Draper

re #6669 added the missing import, removed some print statements

Changeset: 00cafaeb7650030abc22f2ee98a522a5fef91334

comment:13 Changed 8 years ago by Nick Draper

re #6669 added the missing import, removed some print statements

Changeset: 00cafaeb7650030abc22f2ee98a522a5fef91334

comment:14 Changed 8 years ago by Nick Draper

  • Status changed from reopened to accepted

comment:15 Changed 8 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 8 years ago by Nick Draper

re #6669 sorted another missing import

Changeset: b93af3e3133c6950220d35a9e436263bc096db64

comment:17 Changed 8 years ago by Nick Draper

re #6669 sorted another missing import

Changeset: b93af3e3133c6950220d35a9e436263bc096db64

comment:18 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Peter Peterson

comment:19 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to verify
  • Tester Peter Peterson deleted

comment:20 Changed 8 years ago by Peter Peterson

I'm not the guy to test it, but it no longer has the error mentioned in comment:8.

comment:21 Changed 8 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:22 Changed 8 years ago by Wenduo Zhou

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Error was caused by line 73, numpy is used but not imported.

There is no wiki page for this algorithm.

Last edited 8 years ago by Wenduo Zhou (previous) (diff)

comment:23 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:24 Changed 7 years ago by Nick Draper

re #6669 add missing import for numpy

Changeset: c0233bcc695690961189f3df8c528d058c5b9f3e

comment:25 Changed 7 years ago by Nick Draper

re #6669 Dumped branch and started again with fresh master

Changeset: 1a03da36291cd37f913b22c11ceb4ed61a330ad7

comment:26 Changed 7 years ago by Nick Draper

  • Blocking 6668 removed

(In #6668) completed in #6669, therefore duplicate

comment:27 Changed 7 years ago by Nick Draper

re #6669 added test entry to cMakeLists

Changeset: 4186269879f5cdbc6f7b0d9dab2e0e4669ebf6a8

comment:28 Changed 7 years ago by Nick Draper

re #6669 added test entry to cMakeLists

Changeset: 4186269879f5cdbc6f7b0d9dab2e0e4669ebf6a8

comment:29 Changed 7 years ago by Nick Draper

re #6669 fix merge conflict in cmakelists

Changeset: 133607982b7bd5b23167fbd882683b6b3fd140d9

comment:30 Changed 7 years ago by Nick Draper

re #6669 syntax error

Changeset: 0d3347110da2ead12f5b506e0caa0f9bf4004a0c

comment:31 Changed 7 years ago by Nick Draper

re #6669 remove doc block which is causing problems

Changeset: fc3ccd02eb73f0329e8e304b845011b1bbb5289c

comment:32 Changed 7 years ago by Nick Draper

re #6669 damn mixture of tabs and spaces

Changeset: 18e3aa2101894517cd9fd5bcac9c9216f11e1d34

comment:33 Changed 7 years ago by Nick Draper

re #6669 damn mixture of tabs and spaces

Changeset: 9c3690724e824a732ef7cbd07f23dedcf2f4c0b8

comment:34 Changed 7 years ago by Nick Draper

re #6669 move it to the right place

Changeset: 41b28041d3a1f1ca1a617136bd3aef1b9501630f

comment:35 Changed 7 years ago by Nick Draper

re #6669 improve unit tests

Changeset: d637308b5ba2f28145d111f5f67e9ebe8e0d6412

comment:36 Changed 7 years ago by Nick Draper

re #6669 added a test for multiple logs

Changeset: 1ca17a8885215b68e757771f7fff5867f372f2de

comment:37 Changed 7 years ago by Nick Draper

re #6669 syntax error

Changeset: 0d3347110da2ead12f5b506e0caa0f9bf4004a0c

comment:38 Changed 7 years ago by Nick Draper

re #6669 remove doc block which is causing problems

Changeset: fc3ccd02eb73f0329e8e304b845011b1bbb5289c

comment:39 Changed 7 years ago by Nick Draper

re #6669 damn mixture of tabs and spaces

Changeset: 18e3aa2101894517cd9fd5bcac9c9216f11e1d34

comment:40 Changed 7 years ago by Nick Draper

re #6669 damn mixture of tabs and spaces

Changeset: 9c3690724e824a732ef7cbd07f23dedcf2f4c0b8

comment:41 Changed 7 years ago by Nick Draper

re #6669 move it to the right place

Changeset: 41b28041d3a1f1ca1a617136bd3aef1b9501630f

comment:42 Changed 7 years ago by Nick Draper

re #6669 improve unit tests

Changeset: d637308b5ba2f28145d111f5f67e9ebe8e0d6412

comment:43 Changed 7 years ago by Nick Draper

re #6669 added a test for multiple logs

Changeset: 1ca17a8885215b68e757771f7fff5867f372f2de

comment:44 Changed 7 years ago by Nick Draper

  • Description modified (diff)

Tester:

Do not worry about the length of the comments in this ticket, it really isn't that complicated.

Only 3 files affected, A new PythonAlgorithm, a test for it, and a warning fix on MantidDock. To test the PythonAlgorithm LoadLogPropertyTable, use the musr files in autotestdata, or any other range of files.

It should:

  1. Create a tableworkspace of log values against the run number.
  2. Load any file type that Load can handle.
  3. Not crash with multiperiod data - although values will be from period 1
  4. Handle gaps in the file structure (although this can be slow over a network if you choose a range of 100s), there are emu files in autotest data that are used in the unit test for this.
  5. Load only a single spectra of the data (if the file loader supports this).
  6. Print out the list of acceptable log names if one is entered incorrectly.
  7. Use a hidden workspace for the temporary loaded workspaces, and clean up after itself.
  8. Handle multiple logvalues in a single call, the log values can be entered as a comma separated list.

comment:45 Changed 7 years ago by Nick Draper

  • Status changed from reopened to accepted

comment:46 Changed 7 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Tester Wenduo Zhou deleted

comment:47 Changed 7 years ago by Nick Draper

re #6669 Minor formatiing improvement to wiki text

Changeset: 37225d50c4e3e8b05d6973a236a827cb3f159934

comment:48 Changed 7 years ago by Nick Draper

re #6669 removedrelative path to autotestdata

Changeset: c70b750ff3111e929b7f68740e54d37ffff6dcb5

comment:49 Changed 7 years ago by Nick Draper

re #6669 Minor formatiing improvement to wiki text

Changeset: 37225d50c4e3e8b05d6973a236a827cb3f159934

comment:50 Changed 7 years ago by Nick Draper

re #6669 removedrelative path to autotestdata

Changeset: c70b750ff3111e929b7f68740e54d37ffff6dcb5

comment:51 Changed 7 years ago by Nick Draper

re #6669 relax precision of log averaging in tests to handle OS diffs

Changeset: 2b57c072b1a2d3db5fecae9db0a3250152be4df8

comment:52 Changed 7 years ago by Nick Draper

re #6669 relax precision of log averaging in tests to handle OS diffs

Changeset: 2b57c072b1a2d3db5fecae9db0a3250152be4df8

comment:53 Changed 7 years ago by Nick Draper

re #6669 add wiki summary

Changeset: 64ca1e5b79552f3a80f4f60329ef3f0275e6fa2b

comment:54 Changed 7 years ago by Nick Draper

re #6669 add wiki summary

Changeset: 64ca1e5b79552f3a80f4f60329ef3f0275e6fa2b

comment:55 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:56 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed
  • Unit tests are now fine.
  • Checked all of the things in the list and found an issue with SNS event_nexus files. Raised #7125 to deal with it.
  • All of the error cases I could think of seem to be handled correctly

comment:57 Changed 7 years ago by Nick Draper

re #6669 Dumped branch and started again with fresh master

Changeset: 1a03da36291cd37f913b22c11ceb4ed61a330ad7

comment:58 Changed 7 years ago by Nick Draper

re #6669 added test entry to cMakeLists

Changeset: 4186269879f5cdbc6f7b0d9dab2e0e4669ebf6a8

comment:59 Changed 7 years ago by Nick Draper

re #6669 syntax error

Changeset: 0d3347110da2ead12f5b506e0caa0f9bf4004a0c

comment:60 Changed 7 years ago by Nick Draper

re #6669 remove doc block which is causing problems

Changeset: fc3ccd02eb73f0329e8e304b845011b1bbb5289c

comment:61 Changed 7 years ago by Nick Draper

re #6669 damn mixture of tabs and spaces

Changeset: 18e3aa2101894517cd9fd5bcac9c9216f11e1d34

comment:62 Changed 7 years ago by Nick Draper

re #6669 damn mixture of tabs and spaces

Changeset: 9c3690724e824a732ef7cbd07f23dedcf2f4c0b8

comment:63 Changed 7 years ago by Nick Draper

re #6669 move it to the right place

Changeset: 41b28041d3a1f1ca1a617136bd3aef1b9501630f

comment:64 Changed 7 years ago by Nick Draper

re #6669 improve unit tests

Changeset: d637308b5ba2f28145d111f5f67e9ebe8e0d6412

comment:65 Changed 7 years ago by Nick Draper

re #6669 added a test for multiple logs

Changeset: 1ca17a8885215b68e757771f7fff5867f372f2de

comment:66 Changed 7 years ago by Nick Draper

re #6669 Minor formatiing improvement to wiki text

Changeset: 37225d50c4e3e8b05d6973a236a827cb3f159934

comment:67 Changed 7 years ago by Nick Draper

re #6669 removedrelative path to autotestdata

Changeset: c70b750ff3111e929b7f68740e54d37ffff6dcb5

comment:68 Changed 7 years ago by Nick Draper

re #6669 relax precision of log averaging in tests to handle OS diffs

Changeset: 2b57c072b1a2d3db5fecae9db0a3250152be4df8

comment:69 Changed 7 years ago by Nick Draper

re #6669 add wiki summary

Changeset: 64ca1e5b79552f3a80f4f60329ef3f0275e6fa2b

comment:70 Changed 7 years ago by Nick Draper

Merge branch 'feature/6669_LoadLogPropertyTable' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:71 Changed 7 years ago by Nick Draper

Merge branch 'feature/6669_LoadLogPropertyTable' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:72 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:73 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7515

Note: See TracTickets for help on using tickets.