Ticket #6671 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

GetTimeSeriesLogInformation does not work with MantidPlot GUI

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: lynchve@… Blocked By:
Blocking: Tester: Russell Taylor

Description

GetTimeSeriesLogInformation outputs an EventWorkspace in "Export Log" mode. It is not friendly to the GUI script for filtering events. Make an extra option such that the output can be a Workspace2D object such that each (X, Y) corresponds to one log entry.

MantidPlot is not satisfied with the optional output workspaces of this algorithm when it executes it in Python script environment. Remove "optional" from the declaration of those workspace properties.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Wenduo Zhou

Make changes to this algorithm. Refs #6671.

Changes include (1) Refactor the number and name of output workspaces; (2) Make all output workspaces non-optional to make it work in Python script; (3) Add an option to write out a TimeSeriesProperty log to a Workspace2D workspace; (4) Update the unit test.

Changeset: 3930e2308ab0ca3b13c706107656cc2c521b4260

comment:3 Changed 8 years ago by Wenduo Zhou

Make changes to this algorithm. Refs #6671.

Changes include (1) Refactor the number and name of output workspaces; (2) Make all output workspaces non-optional to make it work in Python script; (3) Add an option to write out a TimeSeriesProperty log to a Workspace2D workspace; (4) Update the unit test.

Changeset: 3930e2308ab0ca3b13c706107656cc2c521b4260

comment:4 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

It was a mistake to have the change made in branch wzhou/6555_powdergui.

How to test

  1. Load HYS_13656_event.nxs in systemtest/Data/;
  2. Run 'GetTimeSeriesLogInformation' with
    • Function = 'Export Log'
    • LogName = 'SensorC'
    • IsEventWorkspace = 'False'
Last edited 8 years ago by Wenduo Zhou (previous) (diff)

comment:5 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:6 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Because this ticket is on the same branch as #6555 I guess they should be tested and closed together.

comment:7 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:8 Changed 8 years ago by Wenduo Zhou

Enable log value to be output to workspace2d. Refs #6671.

Changeset: 60b2a49703b0bd2de719e1ea537dff99857080fe

comment:9 Changed 8 years ago by Wenduo Zhou

Enable log value to be output to workspace2d. Refs #6671.

Changeset: 60b2a49703b0bd2de719e1ea537dff99857080fe

comment:10 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Russell Taylor

comment:12 Changed 8 years ago by Wenduo Zhou

Enable log value to be output to workspace2d. Refs #6671.

Changeset: 60b2a49703b0bd2de719e1ea537dff99857080fe

comment:13 Changed 8 years ago by Wenduo Zhou

Enable log value to be output to workspace2d. Refs #6671.

Changeset: 60b2a49703b0bd2de719e1ea537dff99857080fe

comment:14 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

This algorithm isn't really suitable for use by the general user rather than just developers, but unfortunately in Mantid we don't have a way to corral such algorithms.

Looking just at the changes under this ticket, they do want Wenduo intended.

comment:15 Changed 8 years ago by Wenduo Zhou

Enable log value to be output to workspace2d. Refs #6671.

Changeset: 60b2a49703b0bd2de719e1ea537dff99857080fe

comment:16 Changed 8 years ago by Wenduo Zhou

Enable log value to be output to workspace2d. Refs #6671.

Changeset: 60b2a49703b0bd2de719e1ea537dff99857080fe

comment:17 Changed 8 years ago by Wenduo Zhou

Enable log value to be output to workspace2d. Refs #6671.

Changeset: 60b2a49703b0bd2de719e1ea537dff99857080fe

comment:18 Changed 7 years ago by Wenduo Zhou

Enable log value to be output to workspace2d. Refs #6671.

Changeset: 60b2a49703b0bd2de719e1ea537dff99857080fe

comment:19 Changed 7 years ago by Wenduo Zhou

Make changes to this algorithm. Refs #6671.

Changes include (1) Refactor the number and name of output workspaces; (2) Make all output workspaces non-optional to make it work in Python script; (3) Add an option to write out a TimeSeriesProperty log to a Workspace2D workspace; (4) Update the unit test.

Changeset: 3930e2308ab0ca3b13c706107656cc2c521b4260

comment:20 Changed 7 years ago by Wenduo Zhou

Enable log value to be output to workspace2d. Refs #6671.

Changeset: 60b2a49703b0bd2de719e1ea537dff99857080fe

comment:21 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7517

Note: See TracTickets for help on using tickets.