Ticket #6679 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

UpdatePeakParameterTableValue syntax error

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: blocker Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Python algorithm UpdatePeakParameterTableValue has syntax error at line 52.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

Fix syntax error. Refs #6679.

Changeset: c1a049e955dcd5dea2fcd462ea05e1e622b697f7

comment:2 Changed 8 years ago by Wenduo Zhou

Add unit test for UpdatePeakParameterTableValue. Refs #6679.

Changeset: 7e513a780ee6faf3f17895aeff6c3433a281c2af

comment:3 Changed 8 years ago by Wenduo Zhou

Add unit test for UpdatePeakParameterTableValue. Refs #6679.

Changeset: 65173396452e74cb8b1b284f0adfb0883fca07a0

comment:4 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:5 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:7 Changed 8 years ago by Wenduo Zhou

Fix syntax error. Refs #6679.

Changeset: c1a049e955dcd5dea2fcd462ea05e1e622b697f7

comment:8 Changed 8 years ago by Wenduo Zhou

Add unit test for UpdatePeakParameterTableValue. Refs #6679.

Changeset: 7e513a780ee6faf3f17895aeff6c3433a281c2af

comment:9 Changed 8 years ago by Russell Taylor

Merge remote branch 'origin/wzhou/6679_fixerror'. Re #6679.

Conflicts:

Code/Mantid/Framework/PythonInterface/PythonAlgorithms/UpdatePeakParameterTableValue.py

Changeset: 57d79ea515cd9d0c1edca6fe21ee578234ed1ff6

comment:10 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

Turns out this had been fixed on another branch, but the addition of a unit test - which would have shown the error up automatically - is welcome. Don't know how this got past the testing step when it was introduced though, as it was a pretty obvious error and immediately visible on starting Mantid.

comment:11 Changed 8 years ago by Wenduo Zhou

Fix syntax error. Refs #6679.

Changeset: c1a049e955dcd5dea2fcd462ea05e1e622b697f7

comment:12 Changed 8 years ago by Wenduo Zhou

Add unit test for UpdatePeakParameterTableValue. Refs #6679.

Changeset: 7e513a780ee6faf3f17895aeff6c3433a281c2af

comment:13 Changed 8 years ago by Russell Taylor

Merge remote branch 'origin/wzhou/6679_fixerror'. Re #6679.

Conflicts:

Code/Mantid/Framework/PythonInterface/PythonAlgorithms/UpdatePeakParameterTableValue.py

Changeset: 57d79ea515cd9d0c1edca6fe21ee578234ed1ff6

comment:14 Changed 8 years ago by Wenduo Zhou

Add unit test for UpdatePeakParameterTableValue. Refs #6679.

Changeset: 5dee2a3e9e105e4d6b8bc6bd3050281a3309ffcd

comment:15 Changed 8 years ago by Wenduo Zhou

Fix syntax error. Refs #6679.

Changeset: c1a049e955dcd5dea2fcd462ea05e1e622b697f7

comment:16 Changed 8 years ago by Wenduo Zhou

Add unit test for UpdatePeakParameterTableValue. Refs #6679.

Changeset: 7e513a780ee6faf3f17895aeff6c3433a281c2af

comment:17 Changed 8 years ago by Russell Taylor

Merge remote branch 'origin/wzhou/6679_fixerror'. Re #6679.

Conflicts:

Code/Mantid/Framework/PythonInterface/PythonAlgorithms/UpdatePeakParameterTableValue.py

Changeset: 57d79ea515cd9d0c1edca6fe21ee578234ed1ff6

comment:18 Changed 7 years ago by Wenduo Zhou

Add unit test for UpdatePeakParameterTableValue. Refs #6679.

Changeset: 65173396452e74cb8b1b284f0adfb0883fca07a0

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7525

Note: See TracTickets for help on using tickets.