Ticket #6688 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Remove test in SystemTests.ReduceOneSCD_Run.ReduceOneSCD_Run so sytem test works on Window7 at isis

Reported by: Ruth Mikkelson Owned by: Ruth Mikkelson
Priority: trivial Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description

getDetectorID's did not "match", probably because the id's are 6 or 7 digit integers. Python does not deal with these well.

Change History

comment:1 Changed 8 years ago by Ruth Mikkelson

  • Status changed from new to accepted
  • Owner set to Ruth Mikkelson

comment:2 Changed 8 years ago by Vickie Lynch

Refs #6688 comment test not working on Windows7

Changeset: 63216a7d4a89fa7230168075b97fd32a47f3fe09

comment:3 Changed 8 years ago by Vickie Lynch

Refs #6688 comment test not working on Windows7

Changeset: 63216a7d4a89fa7230168075b97fd32a47f3fe09

comment:4 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:6 Changed 8 years ago by Alex Buts

refs #6688 The test passes on my windows 7, 64 bit machine

Changes to the script, which generate warning if the detector ID are not identical

Changeset: 17d75fcd7ae3191ab19f70f58b269a7ef9348909

comment:7 Changed 8 years ago by Vickie Lynch

Refs #6688 comment test not working on Windows7

Changeset: 63216a7d4a89fa7230168075b97fd32a47f3fe09

comment:8 Changed 8 years ago by Alex Buts

refs #6688 The test passes on my windows 7, 64 bit machine

Changes to the script, which generate warning if the detector ID are not identical

Changeset: 17d75fcd7ae3191ab19f70f58b269a7ef9348909

comment:9 Changed 8 years ago by Alex Buts

  • Status changed from verifying to closed

I can not reproduce the error on my Windows 7 64 bit machine. the test of course passes both in the case when the detID comparison is enabled and disabled too.

I have added the comparison of detID, which generates warning rather then test fail and suggest the ticket owners to think deeper for the reasons why the test is failing on windows.

comment:10 Changed 8 years ago by Vickie Lynch

Refs #6688 comment test not working on Windows7

Changeset: 63216a7d4a89fa7230168075b97fd32a47f3fe09

comment:11 Changed 8 years ago by Alex Buts

refs #6688 The test passes on my windows 7, 64 bit machine

Changes to the script, which generate warning if the detector ID are not identical

Changeset: 17d75fcd7ae3191ab19f70f58b269a7ef9348909

comment:12 Changed 8 years ago by Ruth Mikkelson

Refs #6688 Elim Convert2DiffMD and elim equality tests for row,col of peak

A system test on master at isis failed because the ConvertToDiffractionMD gives random results for the center of the peak. This method is replaced by ConvertToMD, which does not give random results, and testing for peak equality will not require equality of row and column numbers.

Changeset: 09a713dfa64d74307c553bb4098f029b9f280f78

comment:13 Changed 8 years ago by Ruth Mikkelson

Refs #6688 Elim Convert2DiffMD and elim equality tests for row,col of peak

A system test on master at isis failed because the ConvertToDiffractionMD gives random results for the center of the peak. This method is replaced by ConvertToMD, which does not give random results, and testing for peak equality will not require equality of row and column numbers.

Changeset: 09a713dfa64d74307c553bb4098f029b9f280f78

comment:14 Changed 8 years ago by Ruth Mikkelson

Refs #6688 Elim Convert2DiffMD and elim equality tests for row,col of peak

A system test on master at isis failed because the ConvertToDiffractionMD gives random results for the center of the peak. This method is replaced by ConvertToMD, which does not give random results, and testing for peak equality will not require equality of row and column numbers.

Changeset: 09a713dfa64d74307c553bb4098f029b9f280f78

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7534

Note: See TracTickets for help on using tickets.